-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CI: Add Apple Silicon (macOS aarch64) to the CI matrix #505
Conversation
@DilumAluthge Do you know how to enable apple silicon support? Apparently the path being constructed is incorrect. |
It's trying to pull Julia from this URL: https://julialangnightlies-s3.julialang.org/bin/mac/aarch64/julia-latest-mac64.tar.gz but the correct URL is https://julialang-s3.julialang.org/bin/mac/aarch64/1.10/julia-1.10.0-macaarch64.tar.gz |
Okay, so this is what I see:
That is, we are calling I think this is a bug in Also cc: @staticfloat to take a look at the S3 download URL. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #505 +/- ##
==========================================
- Coverage 84.60% 84.26% -0.34%
==========================================
Files 12 12
Lines 9122 9122
==========================================
- Hits 7718 7687 -31
- Misses 1404 1435 +31 ☔ View full report in Codecov by Sentry. |
Just a quick aside about the If we only wanted to test on 64-bit Julia (whether x86_64 or aarch64), then we could get rid of all of the |
julia-actions/setup-julia#220 implements support for M1. @DilumAluthge I am still unsure of the exact way to enable M1 in the CI once |
Yeah, I'll update this branch once a new release is made upstream. |
Looks like we're now downloading the correct aarch64 Julia. Huge thanks to @IanButterworth for cutting a new release of setup-julia. @ViralBShah I need to clean up this PR quite a bit, but then we can merge it. |
I don't understand the PR. I thought I suppose this is under experimentation and will settle down eventually. |
Maybe listing all the things to include may be easier than listing all the things to exclude :-) |
@DilumAluthge Is this the final state of the CI file to commit? I think it has some experimentation code, that can perhaps be removed. Would be nice to get this merged. |
A lot of the echos are just for debugging, and can likely be removed. But honestly we could merge this as is and clean it up later. |
Thanks @DilumAluthge. I was hoping that adding M1 runners would be simpler - like just adding a new arch or something to the matrix. I suppose as the M1 runner support matures in our infra, it will become easier, at which point I can add it to various other packages. |
@ViralBShah take a look at how Pkg did it JuliaLang/Pkg.jl#3793 |
Thanks - that was exactly what I was looking for. |
GitHub Actions now offers free Apple Silicon macOS runners for public repositories:
https://github.blog/changelog/2024-01-30-github-actions-introducing-the-new-m1-macos-runner-available-to-open-source/
https://discourse.julialang.org/t/github-actions-now-offers-free-apple-silicon-macos-runners-for-public-repositories/109641