Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI: Add Apple Silicon (macOS aarch64) to the CI matrix #3793

Merged
merged 5 commits into from
Feb 13, 2024
Merged

CI: Add Apple Silicon (macOS aarch64) to the CI matrix #3793

merged 5 commits into from
Feb 13, 2024

Conversation

IanButterworth
Copy link
Member

No description provided.

@IanButterworth IanButterworth mentioned this pull request Feb 13, 2024
Merged
@IanButterworth IanButterworth marked this pull request as ready for review February 13, 2024 20:23
@IanButterworth IanButterworth requested a review from a team as a code owner February 13, 2024 20:23
@DilumAluthge
Copy link
Member

Is this actually downloading the correct Julia?

E.g. if I look at https://github.com/JuliaLang/Pkg.jl/actions/runs/7891826267/job/21536978272?pr=3793, I see:

Platform Info:
  OS: macOS (x86_64-apple-darwin22.4.0)
  CPU: 3 × Apple M1 (Virtual)
  WORD_SIZE: 64
  LLVM: libLLVM-16.0.6 (ORCJIT, westmere)

IIUC, this looks like we've downloaded the macOS x86_64 build of Julia, and we're running it on Apple M1 under Rosetta, right?

@DilumAluthge
Copy link
Member

DilumAluthge commented Feb 13, 2024 •
edited
Loading

For contrast, if I look at https://github.com/JuliaSparse/SparseArrays.jl/actions/runs/7891594032/job/21536261812?pr=505 (which is from JuliaSparse/SparseArrays.jl#505), I see:

Platform Info:
  OS: macOS (arm64-apple-darwin22.4.0)
  CPU: 3 × Apple M1 (Virtual)
  WORD_SIZE: 64
  LLVM: libLLVM-16.0.6 (ORCJIT, apple-m1)

@DilumAluthge DilumAluthge changed the title add aarch64 macos CI CI: Add Apple Silicon (macOS aarch64) to the CI matrix Feb 13, 2024
@IanButterworth
Copy link
Member Author

Ok yeah, that's more like it. 20 min on Apple silicon. 35 min on Intel

DilumAluthge
DilumAluthge approved these changes Feb 13, 2024
View reviewed changes
Copy link
Member

@DilumAluthge DilumAluthge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

It would be nice to have a way of programmatically checking that we're not in the "running x86_64 Julia under Rosetta on Apple Silicon" situation, instead of having to manually inspect the logs. But I think we can do that in a follow-up PR.

@IanButterworth IanButterworth merged commit 2571be6 into JuliaLang:master Feb 13, 2024
14 of 15 checks passed
@IanButterworth IanButterworth deleted the ib/macos_aarch64 branch February 13, 2024 22:53
@IanButterworth IanButterworth mentioned this pull request Feb 21, 2024
Merged
KristofferC pushed a commit that referenced this pull request Feb 28, 2024
@IanButterworth @KristofferC
CI: Add Apple Silicon (macOS aarch64) to the CI matrix (#3793)
463fb64 
* add aarch64 macos CI

* fix

* relax tag

* tryfix

* try again
KristofferC pushed a commit that referenced this pull request May 9, 2024
@IanButterworth
CI: Add Apple Silicon (macOS aarch64) to the CI matrix (#3793)
c55b13a 
* add aarch64 macos CI

* fix

* relax tag

* tryfix

* try again
KristofferC pushed a commit that referenced this pull request Jul 5, 2024
@IanButterworth @KristofferC
CI: Add Apple Silicon (macOS aarch64) to the CI matrix (#3793)
a58d1df 
* add aarch64 macos CI

* fix

* relax tag

* tryfix

* try again
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DilumAluthge DilumAluthge DilumAluthge approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@IanButterworth @DilumAluthge