Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

restore three reg tests from #1716 #1720

Merged
merged 5 commits into from
May 28, 2023
Merged

restore three reg tests from #1716 #1720

merged 5 commits into from
May 28, 2023

Conversation

dehann
Copy link
Member

@dehann dehann commented May 28, 2023

fix half of rollover work from:

Still an issue remaining, see comment below

@codecov
Copy link

codecov bot commented May 28, 2023

Codecov Report

Merging #1720 (d8d740d) into master (b7a8d4c) will increase coverage by 1.13%.
The diff coverage is 95.83%.

@@            Coverage Diff             @@
##           master    #1720      +/-   ##
==========================================
+ Coverage   73.62%   74.75%   +1.13%     
==========================================
  Files          75       75              
  Lines        5675     5685      +10     
==========================================
+ Hits         4178     4250      +72     
+ Misses       1497     1435      -62     
Impacted Files Coverage Δ
src/services/NumericalCalculations.jl 70.00% <88.88%> (+3.57%) ⬆️
src/services/CalcFactor.jl 70.70% <100.00%> (+1.36%) ⬆️
src/services/DeconvUtils.jl 70.96% <100.00%> (ø)
src/services/EvalFactor.jl 77.77% <100.00%> (ø)

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@dehann
Copy link
Member Author

dehann commented May 28, 2023

restore different point count N on solve graph, also fix tests:

@error "MUST RESTORE SOLVE WITH DIFFERENT SIZE N"
if false
# Change to N=150 AFTER constructing the graph, so solver must update the belief sample values during inference

@dehann dehann marked this pull request as ready for review May 28, 2023 04:24
@dehann dehann merged commit c95beec into master May 28, 2023
@dehann dehann deleted the 23Q2/test/restore3tests branch November 27, 2024 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant