rework ccw.varValsAll memory for static arrays #1716
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Dehann Fourie <[email protected]>
Update varValsAll_ref branch with latest master
Codecov Report
@@ Coverage Diff @@
## master #1716 +/- ##
==========================================
+ Coverage 66.97% 73.62% +6.64%
==========================================
Files 73 75 +2
Lines 5648 5675 +27
==========================================
+ Hits 3783 4178 +395
+ Misses 1865 1497 -368
... and 22 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Merged
dehann
added a commit
that referenced
this pull request
May 28, 2023
dehann
added a commit
that referenced
this pull request
May 28, 2023
dehann
added a commit
that referenced
this pull request
May 28, 2023
restore three reg tests from #1716
dehann
added a commit
that referenced
this pull request
Oct 20, 2023
restore 3 alternate tests from #1716
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See restore tests at:
EDIT: merging with 6 known test skips. This PR is blocking other work. Will fix and improve the known issues in next PRs. This PR is currently at an okayish point of refactoring and probably good to use this as a new baseline for memory management during nonparametic solve. Many, many improvements to come.
After this merge is not good enough to release a new stable tag. The 6 skipped tests must first be restored.
Far reaching changes and enhancements, including: