Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add dep Manifolds.jl, towards new defs #1209

Merged
merged 3 commits into from
Mar 26, 2021
Merged

add dep Manifolds.jl, towards new defs #1209

merged 3 commits into from
Mar 26, 2021

Conversation

dehann
Copy link
Member

@dehann dehann commented Mar 19, 2021

@codecov
Copy link

codecov bot commented Mar 19, 2021

Codecov Report

Merging #1209 (f9a5bab) into master (7d45670) will increase coverage by 0.12%.
The diff coverage is 83.78%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1209      +/-   ##
==========================================
+ Coverage   74.12%   74.24%   +0.12%     
==========================================
  Files          55       56       +1     
  Lines        4630     4605      -25     
==========================================
- Hits         3432     3419      -13     
+ Misses       1198     1186      -12     
Impacted Files Coverage Δ
src/Factors/Circular.jl 86.95% <0.00%> (ø)
src/Factors/EuclidDistance.jl 30.76% <0.00%> (-2.57%) ⬇️
src/IncrementalInference.jl 87.50% <ø> (ø)
src/TreeDebugTools.jl 50.64% <0.00%> (+0.64%) ⬆️
src/SolveTree.jl 97.36% <83.33%> (-0.20%) ⬇️
src/Deprecated.jl 20.00% <100.00%> (-8.58%) ⬇️
src/FGOSUtils.jl 74.21% <100.00%> (-0.35%) ⬇️
src/Factors/LinearRelative.jl 84.21% <100.00%> (+3.25%) ⬆️
src/JunctionTree.jl 84.63% <100.00%> (+0.06%) ⬆️
src/SolverAPI.jl 89.00% <100.00%> (ø)
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7d45670...f9a5bab. Read the comment docs.

@dehann dehann merged commit 3524f53 into master Mar 26, 2021
@dehann dehann deleted the 21Q1/refac/tomanijl branch April 27, 2021 02:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix naming Sphere1 --> Circle, and add
1 participant