Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parent CSM should resolve sibling init order (if partials or similar) #954

Closed
dehann opened this issue Oct 7, 2020 · 3 comments
Closed

Comments

@dehann
Copy link
Member

dehann commented Oct 7, 2020

Current CSM states 8o.ii, 8o.iii, and 8o.iv require siblings directly request each other's status. That is not according to tree edges, and can therefore likely only occur in the parent (if following structure).

Stems from

Also see pull model,

cc @Affie

@dehann
Copy link
Member Author

dehann commented Oct 7, 2020

see xref #955 for relevant code in src/CSM_SiblDwnInit_fetch.jl

@dehann
Copy link
Member Author

dehann commented Oct 23, 2020

Previously (old fetch CSM model) in cascade tree-init, when siblings cannot resolve their initialization there is a problem of figuring out which sibling should be initialized first. The old fetch code required each clique to resolve the init priority of all its siblings (basically sharing data not along edges of the tree -- really bad).

If cascading and sibling order is required again, these old functions should be performed by the common parent instead and then direct which child to solve first.

@dehann
Copy link
Member Author

dehann commented Dec 18, 2020

I believe this issue was closed with new CSM and X stroke. Cascading might come back later.

@dehann dehann closed this as completed Dec 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant