Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

parent starting down solve too early bug #924

Closed
dehann opened this issue Sep 27, 2020 · 2 comments · Fixed by #958
Closed

parent starting down solve too early bug #924

dehann opened this issue Sep 27, 2020 · 2 comments · Fixed by #958

Comments

@dehann
Copy link
Member

dehann commented Sep 27, 2020

When solving Caesar1D or Hex with tree init, clique 1 starts downsolve before clique 2 completes it's upsolve

@dehann
Copy link
Member Author

dehann commented Oct 8, 2020

Hi @Affie , I was wondering if you could have a go at this issue perhaps please? Should be a basic redirect in old fetch CSM when doing hex init. You can just work from the current testBasicTreeInit.jl test file?

Aside: I think most of #954 will only happen in v0.17 timeframe. That is a larger job than I previously thought -- but at least a bit more standard CSM structure as part of the #754/#910 effort.

@Affie
Copy link
Member

Affie commented Oct 8, 2020

Should be a basic redirect in old fetch CSM when doing hex init

I didn't quite understand this comment but went with something similar to the take! CSM.
see #958

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment