Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

approxConvBinary does not yet support specialSampler #640

Closed
dehann opened this issue Mar 12, 2020 · 3 comments · Fixed by #1152
Closed

approxConvBinary does not yet support specialSampler #640

dehann opened this issue Mar 12, 2020 · 3 comments · Fixed by #1152
Assignees
@dehann
Labels
enhancement feature request maintenance
Milestone
v0.21.0

Comments

@dehann
Copy link
Member

dehann commented Mar 12, 2020

See #639
@dehann dehann added this to the v0.10.x milestone Mar 12, 2020
@dehann
Copy link
Member Author

dehann commented Oct 7, 2020

xref #927

@dehann dehann modified the milestones: v0.0.x, v0.18.0 Oct 28, 2020
@dehann dehann mentioned this issue Nov 13, 2020
Closed
1 task
dehann added a commit that referenced this issue Dec 26, 2020
@dehann
refactoring fmd part 1,
8c10806 
partially address #640, #927.  Stop empty constructor FactorMetadata()
This was referenced Dec 26, 2020
Merged
Closed
Closed
@dehann dehann modified the milestones: v0.19.0, v0.20.0 Dec 30, 2020
@dehann
Copy link
Member Author

dehann commented Jan 4, 2021

Consolidate with regular approxConv, see #927 and #1102 on work to standardize sampling and factor evaluation using CalcFactor.

@dehann dehann modified the milestones: v0.20.0, v0.20.x Jan 4, 2021
@dehann dehann modified the milestones: v0.21.x, v0.21.0 Feb 6, 2021
@dehann
Copy link
Member Author

dehann commented Feb 7, 2021

Also required for DRT to work properly, so must be updated for v0.21 before tagging.

@dehann dehann self-assigned this Feb 7, 2021
@dehann dehann mentioned this issue Feb 7, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dehann dehann

Labels
enhancement feature request maintenance
Projects
None yet
Milestone
v0.21.0
Development

Successfully merging a pull request may close this issue.

update approxConvBinary getSample, import Optim JuliaRobotics/IncrementalInference.jl
1 participant
@dehann