-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AutoMerge: Respect the Override AutoMerge: name similarity is okay
label
#536
Conversation
bump @DilumAluthge |
Should we just rename our label (on the General repo) and remove the colon character? |
I think it's fine, it's nice to not have 2 labels or have to delete the old ones, and it just needs an extra quote |
Bump- would be nice if folks with triage access could help here! |
To be merged once JuliaRegistries/RegistryCI.jl#536 is operational on General
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not thrilled by the fact that we now have to run AutoMerge when labels are added or removed. But, off the top of my head, I can't think of an alternate approach.
And I do think that having this functionality will reduce the amount of time that human registry committers will need to spend. So, let's give this a try.
I've made a few comments, and once those are addressed, I think this is good to go.
We only run when some specific labels are added or removed, not any labels! |
Co-authored-by: Dilum Aluthge <[email protected]>
Co-authored-by: Dilum Aluthge <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's give this a try.
Override AutoMerge: name similarity is okay
labelOverride AutoMerge: name similarity is okay
label
* Upgrade to Documenter v1 * Update make.jl * Update Project.toml --------- Co-authored-by: Eric Hanson <[email protected]>
To be merged once JuliaRegistries/RegistryCI.jl#536 is operational on General Co-authored-by: Dilum Aluthge <[email protected]>
...by turning off the distance check whenever the label is applied. The github action should be updated to activate when labels are added, for best effect, as shown in the example yaml.