CI: Add workflow for author approved label

[ericphanson]

This intends to facilitate AutoMerge reading this label and bypassing some checks if the author approves. The intended use is:

1. AutoMerge would have guidelines that can be bypassed if the author approves. Without approval, these fail and the automerge comment instructs the author (well: whoever registered the version/package) to comment with "approved".
2. If the author does so, that triggers this workflow, which adds the "author-approved" label to the PR
3. The AutoMerge workflow would be updated to retrigger when this label is applied. It would run through the same logic, but this time notice the label, and use it to bypass those checks.

Currently this workflow is useless as AutoMerge does not have such conditional checks, but I wanted to put a PR to try it out.

Note that JuliaRegistries/RegistryCI.jl#536 shows how easy it is to use label information within automerge itself, which I think makes this a viable route.

For the sake of testing, I will add text to trigger the regex:

• Created by: @ericphanson

[ericphanson]

approved

[ericphanson]

Ah, I can't test this here, since it's an issue_comment triggered workflow:

Note: This event will only trigger a workflow run if the workflow file is on the default branch.

I suppose if we merge this, I can test it in a separate PR that could presumably update the workflow and it would get the changes from the branch instead of from main?

[DilumAluthge]

I suppose if we merge this, I can test it in a separate PR that could presumably update the workflow and it would get the changes from the branch instead of from main?

I think, for issue comments and PR comments, it always picks up the workflow file from the default branch :(

We could make a fork of General and do some testing there?

[DilumAluthge]

I wonder if we could come up with a different name other than "author"? In the AutoMerge codebase, we always use "author" to refer to the actual GitHub PR author, so @JuliaRegistrator, @jlbuild, etc.

So it might be a little confusing to also use the same term "author" for the human that triggered Registrator.

Maybe "registration-trigger-user` or something like that?

[ericphanson]

For the label? I think we should make sure it's understandable by the user, so they can know that their approval was picked up correctly. So I think it shouldn't be too obscure. What about package-author-approved?

[ericphanson]

Ok, I've tested it here, and updated this PR.

Mismatch:

Match:

Note the times on the Julia part vary from 1-2s up to 15-20s, I'm not really sure why. However that code only runs when a comment is posted from a non-bot user that includes "approved", so hopefully it doesn't need to run too much.

[DilumAluthge]

Can we also exclude the github-actions[bot] user?

[ericphanson]

I have excluded all bot users

[DilumAluthge]

For the label? I think we should make sure it's understandable by the user, so they can know that their approval was picked up correctly. So I think it shouldn't be too obscure. What about package-author-approved?

Yeah let's go with that.

[ericphanson]

I had already renamed the label to package-author-approved. Just now, I changed the approval string to "merge approved", and realized in fact it is not case-sensitive, as contains is not. I updated the comment with a reference.

I think this is good to go, and am writing a PR to RegistryCI to make use of this in the sequential version skipping check (probably to the delight of like 2 people who like skipping versions). We can also use it for other things down the line.