Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New package: OneHotArrays v0.1.0 #58049

Closed

Conversation

JuliaRegistrator
Copy link
Contributor

UUID: 0b1bfda6-eb8a-41d2-88d8-f5af5cad476f
Repo: https://github.com/FluxML/OneHotArrays.jl.git
Tree: 2f6efe2f76d57a0ee67cb6eff49b4d02fccbd175

Registrator tree SHA: 8e1a5ac2695627143951512d700c7e3c445102ec
@JuliaRegistrator JuliaRegistrator temporarily deployed to stopwatch April 6, 2022 17:28 Inactive
@github-actions
Copy link
Contributor

github-actions bot commented Apr 6, 2022

Your new package pull request met all of the guidelines for auto-merging and is scheduled to be merged when the mandatory waiting period (3 days) has elapsed.

Since you are registering a new package, please make sure that you have read the package naming guidelines: https://julialang.github.io/Pkg.jl/dev/creating-packages/#Package-naming-guidelines-1


If you want to prevent this pull request from being auto-merged, simply leave a comment. If you want to post a comment without blocking auto-merging, you must include the text [noblock] in your comment.

@cossio
Copy link
Contributor

cossio commented Apr 7, 2022

There is also https://github.com/cossio/OneHot.jl, which is already registered. Would it make sense to merge the two into a single package?

@darsnack
Copy link
Contributor

darsnack commented Apr 7, 2022

[noblock]

Do you mean merge OneHotArrays.jl into OneHot.jl?

@cossio
Copy link
Contributor

cossio commented Apr 7, 2022

Given that OneHot.jl was registered first, maybe that's the easiest solution? I'd be happy take a PR, or give you commit permission on OneHot.jl

@darsnack
Copy link
Contributor

darsnack commented Apr 7, 2022

[noblock]

Do you care about backwards compat for OneHot.jl? OneHotArrays.jl has a different underlying implementation. I don't mind merging...though I do think OneHotArrays is a clearer name.

cc @mcabbott @ToucheSir @CarloLucibello for thoughts on this

@cossio
Copy link
Contributor

cossio commented Apr 7, 2022

Not really, can do a breaking release of OneHot.jl.
Although the name OneHotArrays is more explicit, right now if someone tries to install it they will be presented with OneHot first.

The implementations are not that different. Even the constructor of OneHotArray has the same signature in both cases. Though I wonder you put L (the number of categories?) as part of the type?

@ToucheSir
Copy link

[noblock]

I don't have a particular preference for the path to take here, but I agree that OneHotArrays is clearer unless we plan to add more functionality that is not related to the array type in the future.

@github-actions
Copy link
Contributor

github-actions bot commented May 8, 2022

This pull request has been inactive for 30 days and will be automatically closed 7 days from now. If this pull request should not be closed, please either (1) fix the AutoMerge issues and re-trigger Registrator, which will automatically update the pull request, or (2) post a comment explaining why you would like this pull request to be manually merged. [noblock]

@github-actions github-actions bot added the stale label May 8, 2022
@github-actions
Copy link
Contributor

This pull request has been inactive for more than 30 days and has automatically been closed. Feel free to register your package or version again once you fix the AutoMerge issues. [noblock]

@github-actions github-actions bot closed this May 15, 2022
@github-actions github-actions bot deleted the registrator/onehotarrays/0b1bfda6/v0.1.0 branch May 15, 2022 12:55
@cossio
Copy link
Contributor

cossio commented May 15, 2022

I forgot about this. I guess there is also nothing wrong with having both OneHotArrays.jl and OneHot.jl registered.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants