Prepare to register #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I assume we can drop the GPUArrays testing and just use build kite? |
|
My hope was that we could leave GPUArrays testing live, so that testing on a machine without a GPU will still run the GPU tests -- rather than waiting for CI to tell you what's wrong. |
mcabbott
reviewed
Apr 5, 2022
Co-authored-by: Michael Abbott <[email protected]>
|
I recall seeing the build kite error on Flux, and I think @ToucheSir might have fixed it? |
|
Yup, you need to follow the instructions in https://github.com/juliagpu/buildkite#using-secrets to add the encrypted codecov token to the buildkite config. |
ToucheSir
approved these changes
Apr 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Does some clean up and adds docs.