Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Register IncrementalInference: 0.5.5 #49

Merged
merged 1 commit into from
Apr 16, 2019

Conversation

JuliaRegistrator
Copy link
Contributor

IncrementalInference 0.5.5
Proposed by @dehann
Reviewed by @dehann
Reference JuliaRobotics/IncrementalInference.jl#261 (comment)

UUID: 904591bb-b899-562f-9e6f-b8df64c7d480
Repo: https://github.com/JuliaRobotics/IncrementalInference.jl.git
Tree: 6c87e77a76ba249368e0fcf8d23644ac55541894
@StefanKarpinski StefanKarpinski merged commit 09c7ab1 into master Apr 16, 2019
@StefanKarpinski StefanKarpinski deleted the register/IncrementalInference/v0.5.5 branch April 16, 2019 13:57
@dehann
Copy link

dehann commented Apr 16, 2019

Hi, not sure if I did something wrong but I'm having trouble installing IncrementalInference.jl since this PR. Thought I'd ask here first:

Two behaviors seem weird:

  • Trying to install the new version fails hard in Pkg, and
  • where do JuliaRegistrator suggested SHAs for tags come from -- they don't match anything in repo?
    • Similarly for SHA in Versions.toml

I tried installing recent packages that were registered with JuliaRegistrator, and they seem to install fine, although I can't find their new tags on github either.

Installing IIF v0.5.5

Trying to install the new IIF v0.5.5 just results in a hard package error:

$ julia -O3
               _
   _       _ _(_)_     |  Documentation: https://docs.julialang.org
  (_)     | (_) (_)    |
   _ _   _| |_  __ _   |  Type "?" for help, "]?" for Pkg help.
  | | | | | | |/ _` |  |
  | | |_| | | | (_| |  |  Version 1.0.3 (2018-12-18)
 _/ |\__'_|_|_|\__'_|  |  Official https://julialang.org/ release
|__/                   |

julia> mkpath("/tmp/testiif055")
"/tmp/testiif055"

julia> cd("/tmp/testiif055/")

shell> pwd
/tmp/testiif055

(v1.0) pkg> activate .

(testiif055) pkg> add IncrementalInference
  Updating registry at `~/.julia/registries/General`
  Updating git-repo `https://github.com/JuliaRegistries/General.git`
 Resolving package versions...
ERROR: AssertionError: p0 ≠ p1
Stacktrace:
 [1] Pkg.GraphType.Graph(::Dict{Base.UUID,Set{VersionNumber}}, ::Dict{Base.UUID,Dict{Pkg.Types.VersionRange,Dict{String,Base.UUID}}}, ::Dict{Base.UUID,Dict{Pkg.Types.VersionRange,Dict{String,Pkg.Types.VersionSpec}}}, ::Dict{Base.UUID,String}, ::Dict{Base.UUID,Pkg.Types.VersionSpec}, ::Dict{Base.UUID,Pkg.Types.Fixed}, ::Bool) at /buildworker/worker/package_linux64/build/usr/share/julia/stdlib/v1.0/Pkg/src/GraphType.jl:315
 [2] deps_graph(::Pkg.Types.Context, ::Dict{Base.UUID,String}, ::Dict{Base.UUID,Pkg.Types.VersionSpec}, ::Dict{Base.UUID,Pkg.Types.Fixed}) at /buildworker/worker/package_linux64/build/usr/share/julia/stdlib/v1.0/Pkg/src/Operations.jl:307
 [3] resolve_versions!(::Pkg.Types.Context, ::Array{Pkg.Types.PackageSpec,1}, ::Nothing) at /buildworker/worker/package_linux64/build/usr/share/julia/stdlib/v1.0/Pkg/src/Operations.jl:371
 [4] resolve_versions! at /buildworker/worker/package_linux64/build/usr/share/julia/stdlib/v1.0/Pkg/src/Operations.jl:316 [inlined]
 [5] #add_or_develop#62(::Array{Base.UUID,1}, ::Symbol, ::Function, ::Pkg.Types.Context, ::Array{Pkg.Types.PackageSpec,1}) at /buildworker/worker/package_linux64/build/usr/share/julia/stdlib/v1.0/Pkg/src/Operations.jl:1201
 [6] #add_or_develop at ./none:0 [inlined]
 [7] #add_or_develop#13(::Symbol, ::Bool, ::Base.Iterators.Pairs{Union{},Union{},Tuple{},NamedTuple{(),Tuple{}}}, ::Function, ::Pkg.Types.Context, ::Array{Pkg.Types.PackageSpec,1}) at /buildworker/worker/package_linux64/build/usr/share/julia/stdlib/v1.0/Pkg/src/API.jl:64
 [8] (::getfield(Pkg.API, Symbol("#kw##add_or_develop")))(::NamedTuple{(:mode,),Tuple{Symbol}}, ::typeof(Pkg.API.add_or_develop), ::Pkg.Types.Context, ::Array{Pkg.Types.PackageSpec,1}) at ./none:0
 [9] do_add!(::Dict{Symbol,Any}, ::Array{Pkg.Types.PackageSpec,1}, ::Dict{Symbol,Any}) at /buildworker/worker/package_linux64/build/usr/share/julia/stdlib/v1.0/Pkg/src/REPLMode.jl:709
 [10] #invokelatest#1(::Base.Iterators.Pairs{Union{},Union{},Tuple{},NamedTuple{(),Tuple{}}}, ::Function, ::Any, ::Any, ::Vararg{Any,N} where N) at ./essentials.jl:697
 [11] invokelatest(::Any, ::Any, ::Vararg{Any,N} where N) at ./essentials.jl:696
 [12] do_cmd!(::Pkg.REPLMode.PkgCommand, ::REPL.LineEditREPL) at /buildworker/worker/package_linux64/build/usr/share/julia/stdlib/v1.0/Pkg/src/REPLMode.jl:603
 [13] #do_cmd#33(::Bool, ::Function, ::REPL.LineEditREPL, ::String) at /buildworker/worker/package_linux64/build/usr/share/julia/stdlib/v1.0/Pkg/src/REPLMode.jl:577
 [14] do_cmd at /buildworker/worker/package_linux64/build/usr/share/julia/stdlib/v1.0/Pkg/src/REPLMode.jl:573 [inlined]
 [15] (::getfield(Pkg.REPLMode, Symbol("##50#53")){REPL.LineEditREPL,REPL.LineEdit.Prompt})(::REPL.LineEdit.MIState, ::Base.GenericIOBuffer{Array{UInt8,1}}, ::Bool) at /buildworker/worker/package_linux64/build/usr/share/julia/stdlib/v1.0/Pkg/src/REPLMode.jl:923
 [16] #invokelatest#1 at ./essentials.jl:697 [inlined]
 [17] invokelatest at ./essentials.jl:696 [inlined]
 [18] run_interface(::REPL.Terminals.TextTerminal, ::REPL.LineEdit.ModalInterface, ::REPL.LineEdit.MIState) at /buildworker/worker/package_linux64/build/usr/share/julia/stdlib/v1.0/REPL/src/LineEdit.jl:2273
 [19] run_frontend(::REPL.LineEditREPL, ::REPL.REPLBackendRef) at /buildworker/worker/package_linux64/build/usr/share/julia/stdlib/v1.0/REPL/src/REPL.jl:1034
 [20] run_repl(::REPL.AbstractREPL, ::Any) at /buildworker/worker/package_linux64/build/usr/share/julia/stdlib/v1.0/REPL/src/REPL.jl:191
 [21] (::getfield(Base, Symbol("##718#720")){Bool,Bool,Bool,Bool})(::Module) at ./client.jl:355
 [22] #invokelatest#1 at ./essentials.jl:697 [inlined]
 [23] invokelatest at ./essentials.jl:696 [inlined]
 [24] run_main_repl(::Bool, ::Bool, ::Bool, ::Bool, ::Bool) at ./client.jl:339
 [25] exec_options(::Base.JLOptions) at ./client.jl:277
 [26] _start() at ./client.jl:425

Not quite sure what to make of this error,

  • checked the IIF.jl/Project.toml version is v0.5.5
  • previous v0.5.4 (done by attobot) as well as master branch were working fine.
  • I did uninstall attobot from the repo, since it seemed unnecessary.

Tagging with SHA number?

The tag and release commit SHAs in the repo relate to actual commits in the code. The SHA number suggested by JuliaRegistrator, and those in Versions.toml, do not match anything in the repo (or at least I cannot find them)?

I tried running the suggested commands, but the tag does not show up on Github as expected.

Additional Info

@StefanKarpinski
Copy link
Contributor

This seems to be a problem with the version resolver—it's encountering an unexpected situation when trying to decide on a set of versions to use here.

@KristofferC
Copy link
Member

This might mean the registry is inconsistent? Cc @carlobaldassi

IIRC we had CI running for METADATA that ensured it was consistent.

@carlobaldassi
Copy link

An assertion error signals a bug somewhere, an inconsistent state should (hopefully) produce an informative error message. I can reproduce this, I'll investigate.

carlobaldassi added a commit to carlobaldassi/Pkg3.jl that referenced this pull request Apr 16, 2019
This fixes JuliaRegistries/General#49. I'm rather surprised that this had never came up before...
bors bot added a commit to JuliaLang/Pkg.jl that referenced this pull request Apr 16, 2019
1154: Fix bug in dependency graph creation r=StefanKarpinski a=carlobaldassi

This fixes JuliaRegistries/General#49. I'm rather surprised that this had never came up before...

Co-authored-by: Carlo Baldassi <[email protected]>
bors bot added a commit to JuliaLang/Pkg.jl that referenced this pull request Apr 16, 2019
1154: Fix bug in dependency graph creation r=fredrikekre a=carlobaldassi

This fixes JuliaRegistries/General#49. I'm rather surprised that this had never came up before...

Co-authored-by: Carlo Baldassi <[email protected]>
fredrikekre pushed a commit to JuliaLang/Pkg.jl that referenced this pull request Apr 17, 2019
This fixes JuliaRegistries/General#49. I'm rather surprised that this had never came up before...

(cherry picked from commit ae80eda, PR #1154)
fredrikekre pushed a commit to JuliaLang/Pkg.jl that referenced this pull request Apr 17, 2019
This fixes JuliaRegistries/General#49. I'm rather surprised that this had never came up before...

(cherry picked from commit ae80eda, PR #1154)
fredrikekre pushed a commit to JuliaLang/Pkg.jl that referenced this pull request Apr 17, 2019
This fixes JuliaRegistries/General#49. I'm rather surprised that this had never came up before...

(cherry picked from commit ae80eda, PR #1154)
@dehann
Copy link

dehann commented Apr 17, 2019

Hi, thanks for the help! Sorry to bother again, I just need a pointer on what to do next please? I'd like to resolve any inconsistent state related to IncrementalInference.jl, however, not sure where / how to start looking.

Second, how do the JuliaRegistrator suggested tag commit SHAs relate to the repo's own commits? I tried and did not see the new tag show up in Github, likely due to variation in the SHA key from current master SHA.

  • suggested SHA:
git tag -a v0.5.5 -m "<description of version>" 6c87e77a76ba249368e0fcf8d23644ac55541894
  • Current IIF master branch SHA is at: 64e0c44

@dehann
Copy link

dehann commented Apr 22, 2019

not able to overwrite v0.5.5 when trying to fix missing compat requirement:
JuliaRobotics/IncrementalInference.jl#261 (comment)

dehann added a commit to dehann/General that referenced this pull request Apr 23, 2019
@dehann dehann mentioned this pull request Apr 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants