Skip to content

Commit

Permalink
Merge #1154
Browse files Browse the repository at this point in the history
1154: Fix bug in dependency graph creation r=StefanKarpinski a=carlobaldassi

This fixes JuliaRegistries/General#49. I'm rather surprised that this had never came up before...

Co-authored-by: Carlo Baldassi <[email protected]>
  • Loading branch information
bors[bot] and carlobaldassi committed Apr 16, 2019
2 parents cdcb04f + ae80eda commit 85a6297
Showing 1 changed file with 3 additions and 1 deletion.
4 changes: 3 additions & 1 deletion src/GraphType.jl
Original file line number Diff line number Diff line change
Expand Up @@ -287,7 +287,9 @@ mutable struct Graph
end
# The remaining dependencies do not have compatibility constraints
for uuid in values(n2u)
get!(req, pdict[uuid]) do; VersionSpec() end
p1 = pdict[uuid]
p1 == p0 && continue
get!(req, p1) do; VersionSpec() end
end
# Translate the requirements into bit masks
# Hot code, measure performance before changing
Expand Down

0 comments on commit 85a6297

Please sign in to comment.