Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revise discretize #503

Merged
merged 25 commits into from
Mar 6, 2019
Merged

Revise discretize #503

merged 25 commits into from
Mar 6, 2019

Conversation

mforets
Copy link
Member

@mforets mforets commented Mar 2, 2019 •
edited by schillic
Loading

Closes #465.
Closes #252.
Closes #193.
Closes #491.
Closes #117.

schillic
schillic reviewed Mar 2, 2019
View reviewed changes
Copy link
Member

@schillic schillic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I realized that this is WIP.

src/ReachSets/discretize.jl Outdated Show resolved Hide resolved
src/ReachSets/discretize.jl Outdated Show resolved Hide resolved
src/ReachSets/discretize.jl Outdated Show resolved Hide resolved
src/ReachSets/discretize.jl Outdated Show resolved Hide resolved
src/ReachSets/discretize.jl Outdated Show resolved Hide resolved
src/ReachSets/discretize.jl Outdated Show resolved Hide resolved
src/ReachSets/discretize.jl Outdated Show resolved Hide resolved
src/ReachSets/discretize.jl Outdated Show resolved Hide resolved
src/ReachSets/discretize.jl Outdated Show resolved Hide resolved
src/ReachSets/discretize.jl Outdated Show resolved Hide resolved
@schillic schillic changed the title Revise discretize WIP Revise discretize Mar 2, 2019
@mforets mforets force-pushed the mforets/revise_discretize branch from 93045f4 to bb9deff Compare March 4, 2019 02:43
@mforets mforets mentioned this pull request Mar 4, 2019
Closed
@mforets
Copy link
Member Author

mforets commented Mar 4, 2019 •
edited
Loading

This PR works with the latest release version of LazySets, v1.8.0.

To use it, do:

$ git checkout 3042236

@mforets mforets changed the title WIP Revise discretize Revise discretize Mar 4, 2019
@mforets mforets requested a review from schillic March 5, 2019 00:54
@schillic
Copy link
Member

schillic commented Mar 5, 2019

To go to a tagged version, you can use the tag name:

git checkout v1.8.0

schillic
schillic reviewed Mar 5, 2019
View reviewed changes
Copy link
Member

@schillic schillic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have not looked at discretize.jl yet.

src/ReachSets/ContinuousPost/BFFPSV18/BFFPSV18.jl Outdated Show resolved Hide resolved
src/ReachSets/ContinuousPost/BFFPSV18/BFFPSV18.jl Outdated Show resolved Hide resolved
src/ReachSets/ContinuousPost/BFFPSV18/check_property.jl Outdated Show resolved Hide resolved
src/Utils/Utils.jl Outdated Show resolved Hide resolved
src/Utils/Utils.jl Outdated Show resolved Hide resolved
test/ReachSets/unit_discretization.jl Show resolved Hide resolved
test/ReachSets/unit_discretization.jl Outdated Show resolved Hide resolved
src/solve.jl Outdated Show resolved Hide resolved
This was referenced Mar 5, 2019
Closed
Open
@mforets mforets requested a review from schillic March 5, 2019 16:04
schillic
schillic reviewed Mar 5, 2019
View reviewed changes
src/Utils/Utils.jl Show resolved Hide resolved
src/Utils/systems.jl Show resolved Hide resolved
@mforets mforets mentioned this pull request Mar 5, 2019
Closed
@mforets mforets mentioned this pull request Mar 5, 2019
Closed
schillic
schillic reviewed Mar 5, 2019
View reviewed changes
Copy link
Member

@schillic schillic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am only halfway through with discretize.jl, but I need a break 😉

src/ReachSets/discretize.jl Outdated Show resolved Hide resolved
src/ReachSets/discretize.jl Outdated Show resolved Hide resolved
src/ReachSets/discretize.jl Outdated Show resolved Hide resolved
schillic
schillic reviewed Mar 5, 2019
View reviewed changes
src/ReachSets/discretize.jl Outdated Show resolved Hide resolved
src/ReachSets/discretize.jl Outdated Show resolved Hide resolved
src/ReachSets/discretize.jl Outdated Show resolved Hide resolved
src/ReachSets/discretize.jl Outdated Show resolved Hide resolved
src/ReachSets/discretize.jl Show resolved Hide resolved
src/ReachSets/discretize.jl Outdated Show resolved Hide resolved
src/ReachSets/discretize.jl Outdated Show resolved Hide resolved
src/ReachSets/discretize.jl Outdated Show resolved Hide resolved
src/ReachSets/discretize.jl Outdated Show resolved Hide resolved
src/ReachSets/discretize.jl Outdated Show resolved Hide resolved
schillic
schillic approved these changes Mar 5, 2019
View reviewed changes
Copy link
Member

@schillic schillic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Most successful (in the sense of closing most issues) pull request so far - great job 👑 🏆

@mforets
Copy link
Member Author

mforets commented Mar 5, 2019

Well, thanks a lot for the review, which made this PR much better.

Such a lengthy changeset is to be avoided, but in this case a lot of issues were connected to each other...

This PR has some overlap with #505 in the sense that it also touches the options file BFFPSV18, but the options changed are different so it shouldn't cause problems.

@mforets mforets mentioned this pull request Mar 6, 2019
Open
@mforets mforets merged commit 2c63c5a into master Mar 6, 2019
@mforets mforets deleted the mforets/revise_discretize branch March 6, 2019 00:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@schillic schillic schillic approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mforets @schillic