Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revise discretize.jl #117

Closed
schillic opened this issue Mar 18, 2018 · 1 comment
Closed

Revise discretize.jl #117

schillic opened this issue Mar 18, 2018 · 1 comment

Comments

@schillic
Copy link
Member

schillic commented Mar 18, 2018

After solving #41, we may want to do some refactorings:

  • Outsource common parts (e.g., the matrix computation) to helper functions.
  • Can we split and determine some functions by types rather than by if-then-else chains?
  • Outsource the file to a different module? (It is used in ReachSets and Properties.) (outdated)
  • Some data is computed several times (e.g., exp(δ*Anorm) - 1. - δ*Anorm). Avoid this.
  • Add an option for trying to invert the matrix in the interpolation method (instead of the 3n×3n matrix computations). see Add an option to discretization for computing the matrix inverse #514
@mforets
Copy link
Member

mforets commented Mar 5, 2019

  • I think that the pull request Revise discretize #503 addresses points 1 and 4.
  • Points 2 is half-addressed since it does not completely remove type checks in the code to handle the inputs, instead of using dispatch -- but i think it is good as is :)
  • Point 3 is not addressed, discretize still lives in the ReachSets module -- i don't have any particular suggestion here. We could move this file upwards to the root src/discretize.jl..
  • Point 5 is interesting and not addressed in Revise discretize #503; in general one can try to invert the matrix P and obtain Phi1 and Phi2 without exponentiation. I don't have an intuition about the outcome but i propose to make a new issue for experiments.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants