#255 - Refactor options #464
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
schillic
force-pushed
the
schillic/255_refactor_options
branch
from
e2fd0c8 to
848b355
Compare
This was referenced Feb 19, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #255.
Notable changes that could be resolved in follow-up work:
:Ngot removed:plot_varsconvenience definition from:varsgot removed (because that is now an algorithm-specific option):set_typeis not defaulting toIntervalanymore if no partition is given:block_typesoptions' default values got partially removed; now we do not use this option anymore if it was not specified:set_type_projand:ε_projare not connected to:set_typeand:εanymore and default toHyperrectangleandInfnowThere are also two bugfixes here. The bugs got uncovered because
:block_typesis not used anymore by default.