Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP Refactor discrete-post-option creation #388

Closed
wants to merge 1 commit into from
Closed

Conversation

schillic
Copy link
Member

@schillic schillic commented Nov 1, 2018

Closes #379.

Now that #464 got merged, these options still need to be revised. So I keep this PR open as a reference, but we should start a new approach.

@schillic schillic requested a review from mforets November 1, 2018 16:26
@mforets
Copy link
Member

mforets commented Nov 1, 2018

This is a valid approach but i have hesitated because removing the function call from Options, we loose:

  • checking that the given option has the good type (merge doesn't know)
  • the debug options (verbose) in check_aliases_and_add_default_value!
  • handling aliases

@schillic
Copy link
Member Author

schillic commented Nov 1, 2018

True, the "real" solution is to have #255.
Both approaches are not perfect. The current implementation uses functions that are not supposed to be used that way. So it is a hack which also does not work.

handling aliases

Currently we do not have aliases for those options.

@schillic schillic changed the title Refactor discrete-post-option creation WIP Refactor discrete-post-option creation Feb 15, 2019
@schillic schillic removed the request for review from mforets March 6, 2019 18:56
@schillic schillic closed this Jul 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Several options aliases warning
2 participants