#484 - Fix membership test of ExponentialMap #485
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mforets
reviewed
Aug 6, 2018
| @@ -253,15 +253,15 @@ This follows from ``\\exp(-M)⋅\\exp(M) = I`` for any ``M``. | |||
| julia> em = ExponentialMap(SparseMatrixExp(SparseMatrixCSC([2.0 0.0; 0.0 1.0])), | |||
| BallInf([1., 1.], 1.)); | |||
|
|
|||
| julia> ∈([5.0, 1.0], em) | |||
| julia> ∈([-1.0, 1.0], em) | |||
There was a problem hiding this comment.
usually we need a space before each julia> for the test to work. does it mean that we are not doctesting
∈(x::AbstractVector{N}, em::ExponentialMap{<:LazySet{N}})::Bool where {N<:Real}There was a problem hiding this comment.
No, the lines below each command must be equal to the output in the REPL. If the command ends with a ;, the REPL just prints an empy line. Hence you need an empty line after each julia> that ends in ;. The doctests worked here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #484.