-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Membership test of ExponentialMap is incorrect #484
Comments
True. The current return ∈(expmv(-one(N), em.spmexp.M, x), em.X) |
The following doctest now does not work anymore. julia> em = ExponentialMap(SparseMatrixExp(SparseMatrixCSC([2.0 0.0; 0.0 1.0])),
BallInf([1., 1.], 1.));
julia> ∈([5.0, 1.0], em)
false Is the expected outcome correct? |
nope. one can observe by plotting both |
How did you plot julia> LazySets.Approximations.box_approximation(em)
ERROR: AssertionError: radius must not be negative Sounds like yet another bug 😞 |
julia> using LazySets, Plots
julia> em = ExponentialMap(SparseMatrixExp(SparseMatrixCSC([2.0 0.0; 0.0 1.0])),
BallInf([1., 1.], 1.));
julia> s = Singleton([5.0, 1.0])
LazySets.Singleton{Float64}([5.0, 1.0])
julia> plot(em, alpha=0.5); plot!(s, alpha=0.4) worked for me. also julia> LazySets.Approximations.box_approximation(em)
LazySets.Hyperrectangle{Float64}([7.38906, 2.71828], [7.38906, 2.71828]) |
What the... it is nondeterministic! |
#484 - Fix membership test of ExponentialMap
Example:
Now since
x ∈ b
, we should expect thatsme * x ∈ sme * b
, or in shortex ∈ em
.However:
The text was updated successfully, but these errors were encountered: