Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#461 - Change VPolytope constructor from VPolygon #464

Merged
merged 1 commit into from
Aug 2, 2018
Merged

#461 - Change VPolytope constructor from VPolygon #464

merged 1 commit into from
Aug 2, 2018

Conversation

schillic
Copy link
Member

@schillic schillic commented Aug 2, 2018

Closes #461.

By default, the vertices are now copied and not shared anymore.

@schillic
change VPolytope constructor from VPolygon
f2b5d85 
By default, the vertices are now copied and not shared anymore.
mforets
mforets approved these changes Aug 2, 2018
View reviewed changes
Copy link
Member

@mforets mforets left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

for more code coverage we could add a docstring and a doctest

@schillic
Copy link
Member Author

schillic commented Aug 2, 2018

There is a test already.
I think we wanted to describe constructors in the docstring of the type itself. And this is not a new feature, just a fix, so I am not legally bound to write it 😁

@schillic schillic merged commit 0228d49 into master Aug 2, 2018
@schillic schillic deleted the schillic/461 branch August 2, 2018 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mforets mforets mforets approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@schillic @mforets