Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VPolytope constructor from VPolygon shares vertices #461

Closed
schillic opened this issue Aug 2, 2018 · 1 comment
Closed

VPolytope constructor from VPolygon shares vertices #461

schillic opened this issue Aug 2, 2018 · 1 comment
Assignees
Labels
fix 🤕 Fix to a problem that is not too serious

Comments

@schillic
Copy link
Member

schillic commented Aug 2, 2018

Is this intended? I would say that this is not a good default behavior; we should copy the array instead.
We could add another parameter that controls sharing/copying.

@schillic schillic added the discussion 🗣️ Requires human input label Aug 2, 2018
@mforets
Copy link
Member

mforets commented Aug 2, 2018

i also agree to change it to copying the array by default: VPolytope(P::VPolygon) = VPolytope(copy(vertices_list(P)))

@schillic schillic added fix 🤕 Fix to a problem that is not too serious and removed discussion 🗣️ Requires human input labels Aug 2, 2018
@schillic schillic self-assigned this Aug 2, 2018
schillic added a commit that referenced this issue Aug 2, 2018
#461 - Change VPolytope constructor from VPolygon
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix 🤕 Fix to a problem that is not too serious
Projects
None yet
Development

No branches or pull requests

2 participants