#162 #145 #165 - add macro to restore old array type behavior

[schillic]

Closes #162 and closes #145 and closes #165.

[mforets]

i fail to see what is the logic for these blocks:

...
        # if the array set type has already been defined, create combinations
        if isdefined(:array_constructor) &&
                method_exists(array_constructor, (Type{$SET},))
            @eval(@array_neutral($(esc(SET)),
                                 $(esc(NEUT)),
                                 array_constructor($(esc(SET)))))
        elseif isdefined(:is_array_constructor) &&
                method_exists(is_array_constructor, (Type{$SET},))
            @eval(@array_neutral($(esc(SET)),
                                 $(esc(NEUT)),
                                 $(esc(SET))))
        end

why is there an if clause? what is the difference between array_constructor and is_array_constructor?

[schillic]

This is needed so that you can use the macros @neutral, @absorbing and @declare_array_version in any order. The if clauses make sure that the functions are defined only once.
array_constructor(MinkowskiSum) == MinkowskiSumArray
is_array_constructor(MinkowskiSum) == false, and is_array_constructor(MinkowskiSumArray) == true

[mforets]

This is needed so that you can use the macros @neutral, @Absorbing and @declare_array_version in any order.

ok

The if clauses make sure that the functions are defined only once.

i guess my confusion arises from the fact that both array_constructor and is_array_constructor are defined in the same place (declare_array_version). how is that we have two @eval's? isn't it used only the first one? thanks

[schillic]

Okay, I admit that it is overengineered :)

We have @neutral two times, once for the normal type and once for the array type.

@neutral(MinkowskiSum, ZeroSet)
@neutral(MinkowskiSumArray, ZeroSet)

Those calls to the macro should have a slightly different behavior. I use the two functions to detect which one.

[mforets]

alright, thanks for the details!