Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move algebraic definitions from functions to constructors #145

Closed
schillic opened this issue Jan 16, 2018 · 0 comments · Fixed by #236
Closed

Move algebraic definitions from functions to constructors #145

schillic opened this issue Jan 16, 2018 · 0 comments · Fixed by #236
Assignees
@schillic
Labels
simplification 👶 Simplifies code

Comments

@schillic
Copy link
Member

For MinkowskiSum and CartesianProduct we have defined neutral/absorbing elements only for the +/* functions, but not for the constructor. It would be more consistent to define them using new constructors so that A + B === MinkowskiSum(A, B) in all cases.

Note that one has to add type parameters to avoid ambiguities. We saw that for ConvexHull where we already have this (because there is no separate function symbol).
@schillic schillic added the simplification 👶 Simplifies code label Jan 16, 2018
@schillic schillic self-assigned this Jan 16, 2018
This was referenced Feb 8, 2018
Merged
Merged
schillic added a commit that referenced this issue Feb 24, 2018
@schillic
Merge pull request #236 from JuliaReach/schillic/162
debde7d 
#162 #145 #165 - add macro to restore old array type behavior
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@schillic schillic

Labels
simplification 👶 Simplifies code
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

#162 #145 #165 - add macro to restore old array type behavior JuliaReach/LazySets.jl
1 participant
@schillic