-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#912 - Quadratic map of a zonotope #2218
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
schillic
reviewed
Jul 15, 2020
SebastianGuadalupe
force-pushed
the
sguadalupe/912
branch
from
July 28, 2020 15:20
b11c664
to
66b7852
Compare
Co-authored-by: Christian Schilling <[email protected]>
Co-authored-by: Christian Schilling <[email protected]>
mforets
reviewed
Jul 28, 2020
mforets
reviewed
Jul 28, 2020
mforets
reviewed
Jul 28, 2020
mforets
reviewed
Jul 29, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm 🎉
tests for the new function are missing
Co-authored-by: Marcelo Forets <[email protected]>
Co-authored-by: Marcelo Forets <[email protected]>
mforets
changed the title
WIP #912 - Quadratic map of a zonotope
#912 - Quadratic map of a zonotope
Jul 29, 2020
When using the function it returns zero generators and some repeated generators, here is an example: N = Float64
Z = Zonotope(N[0, 0], N[1 0; 0 1])
Q1 = N[1/2 0; 0 1/2]
Q2 = N[0 1/2; 1/2 0]
genmat(quadratic_map([Q1, Q2], Z))
2×5 Array{Float64,2}:
0.0 0.0 0.25 0.25 0.0
0.0 0.0 0.0 0.0 1.0 |
mforets
approved these changes
Jul 29, 2020
mforets
reviewed
Jul 29, 2020
schillic
approved these changes
Jul 29, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #912.