Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#1076 - Intersection: assert compactness; generalize to AbstractPolyhedron #1517

Merged
merged 1 commit into from
Jul 30, 2019

Conversation

schillic
Copy link
Member

@schillic schillic commented Jul 23, 2019

Closes #1076.

The second commit is borrowed from #1502.
Reachability tests still pass with this change.

@schillic schillic requested a review from mforets July 23, 2019 08:38
@codecov-io
Copy link

Codecov Report

Merging #1517 into master will increase coverage by 0.02%.
The diff coverage is 25%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1517      +/-   ##
==========================================
+ Coverage   91.01%   91.03%   +0.02%     
==========================================
  Files          74       74              
  Lines        3493     3490       -3     
==========================================
- Hits         3179     3177       -2     
+ Misses        314      313       -1
Impacted Files Coverage Δ
src/Intersection.jl 87.87% <25%> (+2.58%) ⬆️
src/Approximations/box_approximations.jl 94.33% <0%> (-3.78%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a3d24f5...eed366e. Read the comment docs.

1 similar comment
@codecov-io
Copy link

codecov-io commented Jul 23, 2019

Codecov Report

Merging #1517 into master will increase coverage by 0.02%.
The diff coverage is 25%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1517      +/-   ##
==========================================
+ Coverage   91.01%   91.03%   +0.02%     
==========================================
  Files          74       74              
  Lines        3493     3490       -3     
==========================================
- Hits         3179     3177       -2     
+ Misses        314      313       -1
Impacted Files Coverage Δ
src/Intersection.jl 87.87% <25%> (+2.58%) ⬆️
src/Approximations/box_approximations.jl 94.33% <0%> (-3.78%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a3d24f5...eed366e. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use isbounded instead of <: HPolyhedron
3 participants