Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#1449 - Generalize isdisjoint(::CPA, ::HPolyhedron) to AbstractPolyhedron #1502

Merged
merged 3 commits into from
Jul 30, 2019

Conversation

schillic
Copy link
Member

@schillic schillic commented Jul 4, 2019

See #1449.

Some of the tests needed to be changed because we use line search for HalfSpace intersections (which comes with float issues) but another method for HPolyhedron intersection even for just one constraint (i.e., equivalent to a HalfSpace).

@schillic schillic changed the title WIP #1449 - Generalize isdisjoint(::CPA, ::HPolyhedron) to AbstractPolyhedron #1449 - Generalize isdisjoint(::CPA, ::HPolyhedron) to AbstractPolyhedron Jul 5, 2019
@schillic schillic requested a review from mforets July 5, 2019 18:58
Copy link
Member

@mforets mforets left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@schillic schillic merged commit 08b6c5e into master Jul 30, 2019
@schillic schillic deleted the schillic/1421 branch July 30, 2019 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants