Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#1184 - Concrete translation #1192

Merged
merged 3 commits into from
Mar 6, 2019
Merged

#1184 - Concrete translation #1192

merged 3 commits into from
Mar 6, 2019

Conversation

schillic
Copy link
Member

@schillic schillic commented Mar 3, 2019 •
edited
Loading

Closes #1184.

@schillic schillic requested a review from mforets March 3, 2019 20:12
mforets
mforets reviewed Mar 4, 2019
View reviewed changes
src/Ellipsoid.jl Outdated Show resolved Hide resolved
mforets
mforets reviewed Mar 6, 2019
View reviewed changes
src/Ellipsoid.jl Outdated Show resolved Hide resolved
mforets
mforets reviewed Mar 6, 2019
View reviewed changes
src/HPolygon.jl Outdated Show resolved Hide resolved
mforets
mforets reviewed Mar 6, 2019
View reviewed changes
src/HPolygonOpt.jl Outdated Show resolved Hide resolved
mforets
mforets reviewed Mar 6, 2019
View reviewed changes
src/HPolyhedron.jl Outdated Show resolved Hide resolved
mforets
mforets reviewed Mar 6, 2019
View reviewed changes
src/HalfSpace.jl Outdated Show resolved Hide resolved
mforets
mforets reviewed Mar 6, 2019
View reviewed changes
src/Hyperplane.jl Outdated Show resolved Hide resolved
mforets
mforets reviewed Mar 6, 2019
View reviewed changes
src/Hyperrectangle.jl Outdated Show resolved Hide resolved
mforets
mforets reviewed Mar 6, 2019
View reviewed changes
src/Line.jl Outdated Show resolved Hide resolved
mforets
mforets reviewed Mar 6, 2019
View reviewed changes
src/Zonotope.jl Outdated Show resolved Hide resolved
mforets
mforets approved these changes Mar 6, 2019
View reviewed changes
Copy link
Member

@mforets mforets left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I left some updates to the docstrings.

@schillic
Copy link
Member Author

schillic commented Mar 6, 2019

Thanks! I added the changes in the latest commit.

@schillic schillic merged commit 3814618 into master Mar 6, 2019
@schillic schillic deleted the schillic/1184 branch March 6, 2019 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mforets mforets mforets approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@schillic @mforets