Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Concrete translation of basic set types #1184

Closed
mforets opened this issue Mar 1, 2019 · 4 comments
Closed

Concrete translation of basic set types #1184

mforets opened this issue Mar 1, 2019 · 4 comments
Assignees
Labels

Comments

@mforets
Copy link
Member

mforets commented Mar 1, 2019

In #1173 we added a lazy Translation operator.
We should add the concrete operation.

It can preserve the type in many cases, for example, the translation of an abstracthyperrectangle amounts to translating the center. For a general polytopic set, one translates the vertices. For a set represented by constraints, one can translate the constraints using constraints_list(::Translation).

(About the name translate or translation -- I prefer translate ... but for the concrete intersection we kept Intersection for the type and intersection, i wonder we we didn't choose intersect..)

@schillic schillic added the feature ➕ A new feature label Mar 1, 2019
@schillic
Copy link
Member

schillic commented Mar 1, 2019

i wonder we we didn't choose intersect

Because in Julia intersect == ∩.

help?> 
"" can be typed by \cap<tab>

search: 

  intersect(s, itrs...)
  (s, itrs...)

@mforets
Copy link
Member Author

mforets commented Mar 1, 2019

Oh, ok, so the problem was that if we extend intersect then we cannot use the symbol for the lazy operation, as for other types.

@schillic
Copy link
Member

schillic commented Mar 1, 2019

I support translate.

@schillic
Copy link
Member

schillic commented Mar 1, 2019

translating the center

This even extends to the AbstractCentrallySymmetric interface. However, we need to do add a method for every implementing type because there is no generic way to define a new set instance. And moreover, for SymmetricIntervalHull we need to create a Hyperrectangle because the center is fixed.

@schillic schillic self-assigned this Mar 3, 2019
@schillic schillic assigned schillic and unassigned schillic Mar 3, 2019
@schillic schillic changed the title Concrete translation Concrete translation of basic set types Mar 3, 2019
schillic added a commit that referenced this issue Mar 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants