Add Chinese Translation. #45
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adrhill
requested changes
Sep 11, 2024
There was a problem hiding this comment.
Hi @mathutopia, thanks for your contribution!
We had a simultaneous contribution of a Russian translation in #44, which has since been merged. Could you resolve the dependency conflicts by merging main into your branch or rebasing it?
Comment on lines
+36
to
+38
| PlutoTeachingTools.yays(lang::Lang) where {Lang <: Chinese} = [md"Great!", md"Yay ❤", md"Great! 🎉", md"Well done!", md"Keep it up!", md"Good job!", md"Awesome!", md"You got the right answer!", md"Let's move on to the next part."] | ||
| PlutoTeachingTools.correct_str(lang::Lang) where {Lang <: Chinese} = "Got it!" | ||
| PlutoTeachingTools.todo_str(lang::Lang) where {Lang <: Chinese} = "TODO" |
There was a problem hiding this comment.
Looks like these are still missing translations.
adrhill
requested changes
Sep 11, 2024
Comment on lines
+65
to
+70
|
|
||
| abstract type German <: AbstractLanguage end | ||
| struct GermanGermanyFormal <: German end | ||
| struct GermanGermanyColloquial <: German end | ||
| GermanGermany = GermanGermanyFormal | ||
|
|
There was a problem hiding this comment.
These should be removed. They are imported in L59 and unrelated to the Chinese translation.
Suggested change
| abstract type German <: AbstractLanguage end | |
| struct GermanGermanyFormal <: German end | |
| struct GermanGermanyColloquial <: German end | |
| GermanGermany = GermanGermanyFormal |
|
Closed in favor of #46. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add Chinese Translation.