Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CI #1689

Merged
merged 11 commits into from
Aug 26, 2018
+44 −43
Merged

Fix CI #1689

Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
def5be6
Use Pkg3 API in travis_commands.jl
tkf Aug 23, 2018
7fcd008
Fix appveyor.yml
tkf Aug 23, 2018
4a51e4e
Import Random
tkf Aug 23, 2018
374580a
Import Pkg
tkf Aug 23, 2018
80da14c
Use pathof(PlotReferenceImages) instead of Pkg.dir
tkf Aug 24, 2018
e483ce8
Install unregistered packages in test/runtests.jl
tkf Aug 24, 2018
531dd43
Add FileIO to test/REQUIRE
tkf Aug 24, 2018
eefea15
Don't use Base.mean
tkf Aug 24, 2018
ebf3239
Import Gtk in interactive session
tkf Aug 25, 2018
6d0d8ea
Use qualified name Statistics.mean
tkf Aug 25, 2018
e0f9313
Use import PlotReferenceImages
tkf Aug 25, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Use pathof(PlotReferenceImages) instead of Pkg.dir
@tkf
tkf committed Aug 25, 2018
commit 80da14c1fbefcfd92329c32a445941fe84567c27
4 changes: 2 additions & 2 deletions test/imgcomp.jl
View file
Original file line number Diff line number Diff line change
@@ -15,7 +15,7 @@ using VisualRegressionTests

using Plots
# using StatPlots
using Pkg
using PlotReferenceImages
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe just import PlotReferenceImages? You're just using it for pathof, right?

using Random
using Test

@@ -40,7 +40,7 @@ function image_comparison_tests(pkg::Symbol, idx::Int; debug = false, popup = is

# reference image directory setup
# refdir = joinpath(Pkg.dir("ExamplePlots"), "test", "refimg", string(pkg))
refdir = Pkg.dir("PlotReferenceImages", "Plots", string(pkg))
refdir = joinpath(dirname(pathof(PlotReferenceImages)), "..", "Plots", string(pkg))
fn = "ref$idx.png"

# firgure out version info