Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

read nexus tree blocks: with translate tables and networks #197

Merged
merged 2 commits into from
Apr 7, 2023

Conversation

cecileane
Copy link
Member

readNexusTrees changed to readnexus_treeblock
assumptions about network format: based on BEAST2 output.

@cecileane
Copy link
Member Author

@crsl4 : could you please review? This PR is modifying a function that you originally wrote, and that you may be using more often than folks in my group. Also, you may be aware of network-formatting in BEAST2 that I'm not aware of.

@codecov
Copy link

codecov bot commented Apr 7, 2023

Codecov Report

Merging #197 (a0ba93f) into master (6b5828e) will increase coverage by 0.05%.
The diff coverage is 92.07%.

@@            Coverage Diff             @@
##           master     #197      +/-   ##
==========================================
+ Coverage   86.59%   86.65%   +0.05%     
==========================================
  Files          30       30              
  Lines       12553    12630      +77     
==========================================
+ Hits        10870    10944      +74     
- Misses       1683     1686       +3     
Impacted Files Coverage Δ
src/deprecated.jl 100.00% <ø> (ø)
src/readData.jl 65.93% <0.00%> (-0.89%) ⬇️
src/readwrite.jl 81.93% <93.00%> (+1.36%) ⬆️

... and 2 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@crsl4 crsl4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't use this function much. New function looks good (and better!). Thanks Cecile!

@cecileane cecileane merged commit 39c9ee0 into master Apr 7, 2023
@cecileane cecileane deleted the readnexus branch April 7, 2023 19:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants