Add support for the Allocs profiles produced by Julia's Allocs Profiler #46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #46 +/- ##
==========================================
- Coverage 98.22% 96.39% -1.83%
==========================================
Files 2 3 +1
Lines 225 305 +80
==========================================
+ Hits 221 294 +73
- Misses 4 11 +7
Continue to review full report at Codecov.
|
NHDaly
force-pushed
the
nhd-profile-allocs
branch
from
f1505c4 to
8c67750
Compare
Support for visualizing the results from the allocations profiler in draft PR: JuliaLang/julia#42768. This was basically copy/pasted from https://github.com/vilterp/AllocProfileParser.jl.
NHDaly
force-pushed
the
nhd-profile-allocs
branch
from
8c67750 to
a81fb68
Compare
vilterp
approved these changes
Jan 4, 2022
src/allocs_profile.jl
Outdated
| using PProf.OrderedCollections | ||
|
|
||
| # input: e.g. "maybe_handle_const_call! at ./compiler/ssair/inlining.jl:1243" | ||
| function parse_location(loc_str::String) |
7 tasks
* make from_c work * skip Array constructor * Leave out the "skip Array constructor" part for now... Co-authored-by: Nathan Daly <[email protected]>
NHDaly
force-pushed
the
nhd-profile-allocs
branch
from
35bc257 to
8dc2019
Compare
NHDaly
added a commit
to JuliaLang/julia
that referenced
this pull request
Jan 19, 2022
## Overview Record the type and stack of every allocation (or only at a given sample interval), and return as Julia objects. Alternate approach to existing alloc profiler PR: #33467 Complementary to garbage profiler PR: #42658 (maybe there's some nice way to meld them) This may be reinventing the wheel from #33467, but I'm not sure why that one needs stuff like LLVM passes. I mimicked some stuff from it, but this was my attempt to get something up and running. Could easily be missing stuff. ## Usage: ```julia using Profile.Allocs res = Allocs.@Profile sample_rate=0.001 my_func() prof = Allocs.fetch() # do something with `prof` ``` See also: JuliaPerf/PProf.jl#46 for support for visualizing these. Co-authored-by: Nathan Daly <[email protected]>
|
Now that this has landed in Base we should land this |
|
Agreed. Just made some fixups to the API; this is ready to go now! |
alloc prof: memoize stringifying type name
vilterp
approved these changes
Jan 25, 2022
vilterp
reviewed
Jan 25, 2022
| outf = PProf.Allocs.pprof(out=out, web=false) | ||
|
|
||
| # Read the exported profile | ||
| prof = open(io->readproto(io, PProf.perftools.profiles.Profile()), outf, "r") |
There was a problem hiding this comment.
😮 what is this -> syntax??
There was a problem hiding this comment.
Lambda/Closure/Anonymous Function
There was a problem hiding this comment.
oh, of course 🤦♂️ just hadn't seen it without parens I guess
|
Cool! Thanks all - merging now |
|
(leaving the branch up for anyone who had pointed their PProf at it locally) |
LilithHafner
pushed a commit
to LilithHafner/julia
that referenced
this pull request
Feb 22, 2022
## Overview Record the type and stack of every allocation (or only at a given sample interval), and return as Julia objects. Alternate approach to existing alloc profiler PR: JuliaLang#33467 Complementary to garbage profiler PR: JuliaLang#42658 (maybe there's some nice way to meld them) This may be reinventing the wheel from JuliaLang#33467, but I'm not sure why that one needs stuff like LLVM passes. I mimicked some stuff from it, but this was my attempt to get something up and running. Could easily be missing stuff. ## Usage: ```julia using Profile.Allocs res = Allocs.@Profile sample_rate=0.001 my_func() prof = Allocs.fetch() # do something with `prof` ``` See also: JuliaPerf/PProf.jl#46 for support for visualizing these. Co-authored-by: Nathan Daly <[email protected]>
LilithHafner
pushed a commit
to LilithHafner/julia
that referenced
this pull request
Mar 8, 2022
## Overview Record the type and stack of every allocation (or only at a given sample interval), and return as Julia objects. Alternate approach to existing alloc profiler PR: JuliaLang#33467 Complementary to garbage profiler PR: JuliaLang#42658 (maybe there's some nice way to meld them) This may be reinventing the wheel from JuliaLang#33467, but I'm not sure why that one needs stuff like LLVM passes. I mimicked some stuff from it, but this was my attempt to get something up and running. Could easily be missing stuff. ## Usage: ```julia using Profile.Allocs res = Allocs.@Profile sample_rate=0.001 my_func() prof = Allocs.fetch() # do something with `prof` ``` See also: JuliaPerf/PProf.jl#46 for support for visualizing these. Co-authored-by: Nathan Daly <[email protected]>
This was referenced May 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for the Allocs profiles produced by Julia's Allocs Profiler
Support for visualizing the results from the allocations profiler in
draft PR:
JuliaLang/julia#42768.
This was basically copy/pasted from
https://github.com/vilterp/AllocProfileParser.jl.