Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

alloc prof: memoize stringifying type name #48

Conversation

vilterp
Copy link
Collaborator

@vilterp vilterp commented Jan 22, 2022

Before:

95.639299 sec
Pasted Graphic 1

After:

33.457880 sec
image

@codecov-commenter
Copy link

codecov-commenter commented Jan 22, 2022

Codecov Report

Merging #48 (5b54ef3) into nhd-profile-allocs (df43527) will increase coverage by 0.04%.
The diff coverage is 100.00%.

Impacted file tree graph

@@                  Coverage Diff                   @@
##           nhd-profile-allocs      #48      +/-   ##
======================================================
+ Coverage               96.34%   96.39%   +0.04%     
======================================================
  Files                       3        3              
  Lines                     301      305       +4     
======================================================
+ Hits                      290      294       +4     
  Misses                     11       11              
Impacted Files Coverage Δ
src/Allocs.jl 91.25% <100.00%> (+0.46%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update df43527...5b54ef3. Read the comment docs.

@vchuravy vchuravy merged commit be54421 into JuliaPerf:nhd-profile-allocs Jan 23, 2022
Copy link
Member

@NHDaly NHDaly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wow that's crazy. String construction is expensive! Thanks Pete - great idea 💪

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants