Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix OpenBLAS using incorrect instructions #2782

Merged
merged 2 commits into from
Apr 7, 2021
Merged

Fix OpenBLAS using incorrect instructions #2782

merged 2 commits into from
Apr 7, 2021

Conversation

staticfloat
Copy link
Member

@staticfloat staticfloat commented Apr 7, 2021 •
edited by ViralBShah
Loading

We accidentally stopped setting TARGET completely by using FLAGS
instead of flags.

Fixes JuliaLang/LinearAlgebra.jl#834

@staticfloat
Fix OpenBLAS using incorrect instructions
456d02c 
We accidentally stopped setting `TARGET` completely by using `FLAGS`
instead of `flags`.
@staticfloat
Bump OpenBLAS v0.3.13
9d1a6ab
@staticfloat staticfloat mentioned this pull request Apr 7, 2021
Closed
@staticfloat staticfloat merged commit 961883c into master Apr 7, 2021
@staticfloat staticfloat deleted the sf/openblas_fix branch April 7, 2021 22:07
@ViralBShah
Copy link
Member

Should these be mirrored into OpenBLAS32 and the HighCoreCounts also?

@ViralBShah
Copy link
Member

Also, seems like we want to use this version of openblas with 1.6.1. Is julia_compat=1.7 a problem for that? Maybe the simplest thing is to just adopt openblas 0.3.13 in julia 1.7.

@KristofferC

@giordano
Copy link
Member

giordano commented Apr 8, 2021

Should these be mirrored into OpenBLAS32 and the HighCoreCounts also?

Yes, it would be good.

Is julia_compat=1.7 a problem for that?

julia_compat is more for the registry than else, I don't expect it to be a big deal in practice.

@ViralBShah ViralBShah mentioned this pull request Apr 8, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Illegal instruction using openblas 0.3.13+4 on 1.7-dev
3 participants
@staticfloat @ViralBShah @giordano