Skip to content

Commit

Permalink
Fix OpenBLAS using incorrect instructions (#2782)
Browse files Browse the repository at this point in the history
* Fix OpenBLAS using incorrect instructions

We accidentally stopped setting `TARGET` completely by using `FLAGS`
instead of `flags`.

* Bump `OpenBLAS v0.3.13`
  • Loading branch information
staticfloat authored Apr 7, 2021
1 parent 416fc78 commit 961883c
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 2 deletions.
1 change: 1 addition & 0 deletions O/OpenBLAS/[email protected]/build_tarballs.jl
Original file line number Diff line number Diff line change
Expand Up @@ -16,3 +16,4 @@ dependencies = openblas_dependencies()
# Build the tarballs
build_tarballs(ARGS, name, version, sources, script, platforms, products, dependencies;
preferred_gcc_version=v"6", lock_microarchitecture=false, julia_compat="1.7")

4 changes: 2 additions & 2 deletions O/OpenBLAS/common.jl
Original file line number Diff line number Diff line change
Expand Up @@ -86,9 +86,9 @@ function openblas_script(;num_64bit_threads::Integer=32, openblas32::Bool=false,
# Before OpenBLAS 0.3.13, there appears to be a miscompilation bug with `clang` on setting `TARGET=GENERIC`
# As that is the case, we're just going to be safe and only use `TARGET=GENERIC` on 0.3.13+
if [ ${version_patch} -gt 12 ]; then
FLAGS+=(TARGET=GENERIC)
flags+=(TARGET=GENERIC)
else
FLAGS+=(TARGET=)
flags+=(TARGET=)
fi
elif [[ ${target} == aarch64-* ]] && [[ ${bb_full_target} != *-libgfortran3* ]]; then
flags+=(TARGET=ARMV8 DYNAMIC_ARCH=1)
Expand Down

0 comments on commit 961883c

Please sign in to comment.