Add derivatives for ellipk and ellipe
#370
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #370 +/- ##
==========================================
- Coverage 91.89% 91.79% -0.11%
==========================================
Files 12 12
Lines 2790 2791 +1
==========================================
- Hits 2564 2562 -2
- Misses 226 229 +3
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
devmotion
commented
Dec 16, 2021
test/chainrules.jl
Outdated
| @@ -37,6 +37,12 @@ | |||
| test_scalar(airyaiprimex, x) | |||
| end | |||
| end | |||
|
|
|||
| # finite differencing fails for x = 0 | |||
There was a problem hiding this comment.
This is wrong, I misinterpreted the ChainRules tests. I always mix up what "expected" and "actual" refer to.
There was a problem hiding this comment.
I added the limit of the derivative at 0 as a special case.
stevengj
approved these changes
Jan 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds derivatives for the elliptic integrals
ellipkandellipe. Moreover, it removes the explicitMethodErrors definitions and potential StackOverflow errors in the same way as in e.g. #353 and #347.