-
Notifications
You must be signed in to change notification settings - Fork 100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Throw MethodError instead of StackOverflowError for gamma
, loggamma
, and logabsgamma
#347
Conversation
…amma` and `logabsgamma`
Codecov Report
@@ Coverage Diff @@
## master #347 +/- ##
==========================================
+ Coverage 92.23% 92.90% +0.67%
==========================================
Files 12 12
Lines 2717 2706 -11
==========================================
+ Hits 2506 2514 +8
+ Misses 211 192 -19
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
According to @stevengj's suggestion
Thanks! |
This PR ensures that
MethodError
s are thrown instead ofStackOverflowError
s ifgamma
,loggamma
andlogabsgamma
are called with arguments for which no fallback exists. Additionally, the dispatches forgamma
andlogabsgamma
are simplified.It is a more general alternative to #295.
Fixes #339.
Fixes #233.