Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump codecov/codecov-action from 3 to 4 #294

Merged
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion .github/workflows/CI.yml
Original file line number Diff line number Diff line change
Expand Up @@ -67,8 +67,10 @@ jobs:
run: julia --project .github/set_ci_preferences.jl "${{ matrix.provider }}"
- uses: julia-actions/julia-runtest@v1
- uses: julia-actions/julia-processcoverage@v1
- uses: codecov/codecov-action@v3
- uses: codecov/codecov-action@v4
with:
fail_ci_if_error: true
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise codecov failures are silent, which eg caused many packages to upgrade to v4 of the action without noticing that it actually broke codecov integration since tokenless uploads are not supported anymore.

Copy link
Member

@giordano giordano Apr 1, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, now it's failing for no apparent good reason, making all CI red when the tests are not actually failing.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AFAICT it is failing for a good reason - the token is missing. I'm pretty sure it actually exists though (tests passed in this PR!) but that the problem in the linked run is that dependabot prs don't have access to secrets. Typically retriggering CI (eg by closing and reopening the PR) fixes these problems with insufficient dependabot permissions.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it is failing for a good reason - the token is missing

No, it's not, it has been there for two months, it has worked so far and it started failing only now

image

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I meant: In the run you pointed to - there it was missing because runs triggered by dependabot PRs do not have access to secrets. As I said, I was certain that the token is there in principle. As suspected, closing and reopening the dependabot PR fixed the CI issues.

token: ${{ secrets.CODECOV_TOKEN }} # required
file: lcov.info
devmotion marked this conversation as resolved.
Show resolved Hide resolved

Documentation:
Expand Down
Loading