Bump codecov/codecov-action from 3 to 4 #294
Conversation
![dependabot[bot]](https://avatars.githubusercontent.com/in/29110?s=60&v=4){kind=small}
Bumps [codecov/codecov-action](https://github.com/codecov/codecov-action) from 3 to 4. - [Release notes](https://github.com/codecov/codecov-action/releases) - [Changelog](https://github.com/codecov/codecov-action/blob/main/CHANGELOG.md) - [Commits](codecov/codecov-action@v3...v4) --- updated-dependencies: - dependency-name: codecov/codecov-action dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #294 +/- ##
=======================================
Coverage 73.08% 73.08%
=======================================
Files 5 5
Lines 535 535
=======================================
Hits 391 391
Misses 144 144 ☔ View full report in Codecov by Sentry. |
dependabot
bot
deleted the
dependabot/github_actions/codecov/codecov-action-4
branch
| with: | ||
| fail_ci_if_error: true |
There was a problem hiding this comment.
Why? Now all CI jobs are failing: https://github.com/JuliaMath/FFTW.jl/actions/runs/8512723230/job/23314911109?pr=300
There was a problem hiding this comment.
Otherwise codecov failures are silent, which eg caused many packages to upgrade to v4 of the action without noticing that it actually broke codecov integration since tokenless uploads are not supported anymore.
There was a problem hiding this comment.
Well, now it's failing for no apparent good reason, making all CI red when the tests are not actually failing.
There was a problem hiding this comment.
AFAICT it is failing for a good reason - the token is missing. I'm pretty sure it actually exists though (tests passed in this PR!) but that the problem in the linked run is that dependabot prs don't have access to secrets. Typically retriggering CI (eg by closing and reopening the PR) fixes these problems with insufficient dependabot permissions.
There was a problem hiding this comment.
it is failing for a good reason - the token is missing
No, it's not, it has been there for two months, it has worked so far and it started failing only now
There was a problem hiding this comment.
I meant: In the run you pointed to - there it was missing because runs triggered by dependabot PRs do not have access to secrets. As I said, I was certain that the token is there in principle. As suspected, closing and reopening the dependabot PR fixed the CI issues.
Bumps codecov/codecov-action from 3 to 4.
Release notes
Sourced from codecov/codecov-action's releases.
... (truncated)
Changelog
Sourced from codecov/codecov-action's changelog.
... (truncated)
Commits
e0b68c6fix: show both token uses in readme (#1250)1f9f557Add all args (#1245)09686fcUpdate README.md (#1243)f30e495fix: update action.yml (#1240)a7b945cfix: allow for other archs (#1239)98ab2c5Update package.json (#1238)43235ccUpdate README.md (#1237)0cf8684chore(ci): bump to node20 (#1236)8e1e730build(deps-dev): bump@typescript-eslint/eslint-pluginfrom 6.19.1 to 6.20.0 ...61293afbuild(deps-dev): bump@typescript-eslint/parserfrom 6.19.1 to 6.20.0 (#1235)Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)