Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add some type annotations in GeneralUnitaryMatrices get_vector #770

Merged
merged 4 commits into from
Nov 27, 2024
Merged

Add some type annotations in GeneralUnitaryMatrices get_vector #770

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
8c95040
Add some type annotations in GeneralUnitaryMatrices get_vector
mateuszbaran Nov 24, 2024
9af071f
disambiguate
mateuszbaran Nov 24, 2024
5249907
Merge branch 'master' into mbaran/types-gum
mateuszbaran Nov 27, 2024
fcd456f
revert docs to building with Julia 1.10, bump quarto version
mateuszbaran Nov 27, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions NEWS.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,12 @@ All notable changes to this project will be documented in this file.
The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).

## [0.10.8] – unreleased

### Changed

Some methods related to `get_vector` for `GeneralUnitaryMatrices` now have `AbstractVector` upper bound for coefficients.

## [0.10.7] – 2024-11-16

### Added
Expand Down
2 changes: 1 addition & 1 deletion Project.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
name = "Manifolds"
uuid = "1cead3c2-87b3-11e9-0ccd-23c62b72b94e"
authors = ["Seth Axen <[email protected]>", "Mateusz Baran <[email protected]>", "Ronny Bergmann <[email protected]>", "Antoine Levitt <[email protected]>"]
version = "0.10.7"
version = "0.10.8"

[deps]
Einsum = "b7d42ee7-0b51-5a75-98ca-779d3107e4c0"
Expand Down
8 changes: 4 additions & 4 deletions src/manifolds/GeneralUnitaryMatrices.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -509,7 +509,7 @@ function get_vector_orthogonal!(
::GeneralUnitaryMatrices{TypeParameter{Tuple{1}},ℝ},
X,
p,
Xⁱ,
Xⁱ::AbstractVector,
N::RealNumbers,
)
return X .= 0
Expand All @@ -518,7 +518,7 @@ function get_vector_orthogonal!(
M::GeneralUnitaryMatrices{TypeParameter{Tuple{2}},ℝ},
X,
p,
Xⁱ,
Xⁱ::AbstractVector,
N::RealNumbers,
)
return get_vector_orthogonal!(M, X, p, Xⁱ[1], N)
Expand All @@ -543,7 +543,7 @@ function get_vector_orthogonal!(
M::GeneralUnitaryMatrices{TypeParameter{Tuple{n}},ℝ},
X,
p,
Xⁱ,
Xⁱ::AbstractVector,
::RealNumbers,
) where {n}
@assert size(X) == (n, n)
Expand Down Expand Up @@ -622,7 +622,7 @@ function get_vector_orthonormal!(
M::GeneralUnitaryMatrices{<:Any,ℝ},
X,
p,
Xⁱ,
Xⁱ::AbstractVector,
N::RealNumbers,
)
T = Base.promote_eltype(p, X)
Expand Down
Loading