Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add some type annotations in GeneralUnitaryMatrices get_vector #770

Merged
merged 4 commits into from
Nov 27, 2024

Conversation

mateuszbaran
Copy link
Member

I had a nasty infinite recursion due to lack of an upper bound for that type. This didn't exactly solve the recursion but at least it was a less bad one with a useful stack trace.

Copy link
Member

@kellertuer kellertuer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While I am not sure there might be someone coming along with more general “vectory-things” for the coordinates, this looks good to me in general.

Copy link

codecov bot commented Nov 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.36%. Comparing base (c0a2344) to head (fcd456f).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #770   +/-   ##
=======================================
  Coverage   96.36%   96.36%           
=======================================
  Files         124      124           
  Lines       11582    11582           
=======================================
  Hits        11161    11161           
  Misses        421      421           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mateuszbaran
Copy link
Member Author

In a few places we allow using plain numbers for coordinates (if there is only one coordinate). Other than this, <:AbstractVector shouldn't be an issue.

@mateuszbaran
Copy link
Member Author

I will merge this when CI passes and tag 0.10.8.

@mateuszbaran mateuszbaran added the preview docs Add this label if you want to see a PR-preview of the documentation label Nov 27, 2024
@kellertuer
Copy link
Member

You also have to update the _quarto.yml if you bump the docs CI Julia version

@mateuszbaran
Copy link
Member Author

I've reverted to building documentation on Julia 1.10 because the config file for quarto (used for some documentation pages) has the version of Julia in it and I don't know if we can have it automatically inferred.

@kellertuer
Copy link
Member

No, you have to switch the version in both, I do not think this can be inferred.

@mateuszbaran
Copy link
Member Author

Then maybe let's keep both at 1.10 for now. #772 changed it from "1.10" to "1" which won't work, so here I'm reverting this change.

@kellertuer
Copy link
Member

I would be fine moving both to 1.11, but sure, staying on 1.10 is also fine with me and sure it should be consistent.

@mateuszbaran mateuszbaran merged commit bcbc7d2 into master Nov 27, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
preview docs Add this label if you want to see a PR-preview of the documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants