-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add some type annotations in GeneralUnitaryMatrices
get_vector
#770
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While I am not sure there might be someone coming along with more general “vectory-things” for the coordinates, this looks good to me in general.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #770 +/- ##
=======================================
Coverage 96.36% 96.36%
=======================================
Files 124 124
Lines 11582 11582
=======================================
Hits 11161 11161
Misses 421 421 ☔ View full report in Codecov by Sentry. |
In a few places we allow using plain numbers for coordinates (if there is only one coordinate). Other than this, |
I will merge this when CI passes and tag 0.10.8. |
You also have to update the |
I've reverted to building documentation on Julia 1.10 because the config file for quarto (used for some documentation pages) has the version of Julia in it and I don't know if we can have it automatically inferred. |
No, you have to switch the version in both, I do not think this can be inferred. |
Then maybe let's keep both at 1.10 for now. #772 changed it from "1.10" to "1" which won't work, so here I'm reverting this change. |
I would be fine moving both to 1.11, but sure, staying on 1.10 is also fine with me and sure it should be consistent. |
I had a nasty infinite recursion due to lack of an upper bound for that type. This didn't exactly solve the recursion but at least it was a less bad one with a useful stack trace.