Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Symplectic Grassmann #700

Merged
merged 70 commits into from
Jan 25, 2024
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
70 commits
Select commit Hold shift + click to select a range
592e3a0
Start documentation of the symplectic Grassmann.
kellertuer Dec 23, 2023
c4f69c3
Merge branch 'master' into kellertuer/more-grassmann
kellertuer Dec 29, 2023
0ed78d5
Finish manifold doc string by adding the tangent spaces.
kellertuer Jan 3, 2024
3b3d1e3
A bit of work on the symplectic inverse.
kellertuer Jan 3, 2024
5d800f6
Adapt a few docs and default shows, implement symplectic Grassmann ch…
kellertuer Jan 5, 2024
c80df09
Undo a chick search-and-replace, that was not careful enough.
kellertuer Jan 5, 2024
60d2944
Fix docs and tests.
kellertuer Jan 5, 2024
95c9848
Further work on Symplectic Grasmann
kellertuer Jan 9, 2024
01434a8
Unify notation to use UTF8 where possible and use J for the symplecti…
kellertuer Jan 11, 2024
5f6409f
delete an accidentially moved file
kellertuer Jan 11, 2024
ab162ba
Worked a bit on math formulae.
kellertuer Jan 11, 2024
770bf76
Rearrange code to avoid redefining functions.
kellertuer Jan 12, 2024
f9769a1
Fix improvised test, fix documentation.
kellertuer Jan 13, 2024
3f5137e
implement `rand!` for Hamiltonians. Deprecate `rand_hamiltonian`.
kellertuer Jan 14, 2024
f4f6cef
Implement exp and the Caley retraction in the quivalence class repres…
kellertuer Jan 15, 2024
5b22c6c
Simplify math.
kellertuer Jan 15, 2024
8982971
Deprecate Symplectic in favour of SymplecticMatrices (cf. #701 Point 1)
kellertuer Jan 18, 2024
385f9b5
Rename SymplecticMatrix to SymplecticElement (#701, Point 2).
kellertuer Jan 18, 2024
de1cee2
this fixes a typo and I am getting a bit tired so I should stop also …
kellertuer Jan 18, 2024
9f8b719
Fix references.
kellertuer Jan 19, 2024
9173543
Unify and extend rands. Introduce Riemannian Gradients.
kellertuer Jan 19, 2024
273de80
Apply suggestions from code review
kellertuer Jan 19, 2024
72d04e1
Fix 2 typos.
kellertuer Jan 19, 2024
9b3dee3
Replace \to with → in LaTeX formulae.
kellertuer Jan 20, 2024
52db300
Start new test file, fix an old test.
kellertuer Jan 20, 2024
009622b
Fix News.md
kellertuer Jan 20, 2024
aca6452
Improve memory a bit.
kellertuer Jan 20, 2024
1e9da05
Fix doc strings.
kellertuer Jan 20, 2024
22717df
$ → `` for math, \mathbb R → ℝ
kellertuer Jan 20, 2024
4d5c62c
Missed a p.
kellertuer Jan 20, 2024
020b0b5
And another symbol.
kellertuer Jan 20, 2024
08712a2
My VS Code reportet an error on this line, removing the "" fixed it, …
kellertuer Jan 20, 2024
c193a8e
Code Coverage for Symplectic Stiefel.
kellertuer Jan 20, 2024
7af7ae3
Work on Symplectic test coverage.
kellertuer Jan 20, 2024
8021ed1
fix a typo.
kellertuer Jan 21, 2024
b94a8e4
A few more tests.
kellertuer Jan 21, 2024
e10d353
Fix embedding functions.
kellertuer Jan 21, 2024
4a149fc
add a few nicer functions to Hamiltonian and extend test coverage.
kellertuer Jan 21, 2024
ef55fa7
Mixinf Hamiltonian with other matrices introduces 120+ ambiguities, l…
kellertuer Jan 21, 2024
e4015ab
Forgot to remove the mixed tests. Brain is melting.
kellertuer Jan 21, 2024
09202d0
fix a too strict test.
kellertuer Jan 21, 2024
b1548bb
MOre tst coverage.
kellertuer Jan 21, 2024
d587821
Merge branch 'master' into kellertuer/more-grassmann
kellertuer Jan 21, 2024
1ed51cb
A bit of testcoverage
kellertuer Jan 22, 2024
bece83a
Maybe increase test cov.
kellertuer Jan 22, 2024
fc4c1e5
Merge branch 'master' into kellertuer/more-grassmann
kellertuer Jan 23, 2024
324c791
This should finish code coverage up to one final line, a valid Projec…
kellertuer Jan 23, 2024
1a21e9b
Add a line for the case that the vector is correct to return nothing.
kellertuer Jan 23, 2024
2f438e2
Checking a new formula for the conversion, still have to debug this.
kellertuer Jan 23, 2024
1958357
Fix a test,
kellertuer Jan 24, 2024
b986b8b
finish tests. 🚀
kellertuer Jan 24, 2024
db2ce47
Apply suggestions from code review
kellertuer Jan 24, 2024
c2b71bc
Fiinalise PR by fixing rand on Hamiltonian and update the docs for SpGr.
kellertuer Jan 24, 2024
bfac83e
bump version.
kellertuer Jan 24, 2024
6fb6287
More $ -> `` (trying to remove the one warning from documenter but ca…
kellertuer Jan 24, 2024
6d577ea
Apply suggestions from code review
kellertuer Jan 24, 2024
2657758
fix test tolerances.
kellertuer Jan 24, 2024
91a09eb
Update src/manifolds/SymplecticGrassmann.jl
kellertuer Jan 24, 2024
02a59f5
Edit rand doc string.
kellertuer Jan 24, 2024
68b3430
Merge branch 'kellertuer/more-grassmann' of github.com:JuliaManifolds…
kellertuer Jan 24, 2024
22b27ff
Update src/manifolds/Hamiltonian.jl
kellertuer Jan 24, 2024
7cf4731
Update src/manifolds/Hamiltonian.jl
kellertuer Jan 24, 2024
d281355
Update src/manifolds/Hamiltonian.jl
kellertuer Jan 24, 2024
e3d83da
Update src/manifolds/Hamiltonian.jl
kellertuer Jan 24, 2024
32aa72e
Update src/manifolds/SymplecticGrassmannStiefel.jl
kellertuer Jan 24, 2024
cff3387
Adress points from code review.
kellertuer Jan 24, 2024
c25e870
I am not sure which AI / auotcomplete stepped in there :/.
kellertuer Jan 24, 2024
6eb0d3e
Rephrase a docstring.
kellertuer Jan 25, 2024
1a8db36
Merge branch 'kellertuer/more-grassmann' of github.com:JuliaManifolds…
kellertuer Jan 25, 2024
9500bd5
Fix the seed, raise tolerances – again.
kellertuer Jan 25, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Apply suggestions from code review
Co-authored-by: Mateusz Baran <[email protected]>
  • Loading branch information
kellertuer and mateuszbaran authored Jan 19, 2024
commit 273de800d04559922ddd74453042480b83ad8365
2 changes: 1 addition & 1 deletion docs/src/manifolds/fiber_bundle.md
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ Fiber bundle $E$ is a manifold that is built on top of another manifold $\mathca
It is characterized by a continuous function $Π : E → \mathcal M$. For each point $p ∈ \mathcal M$ the preimage of $p$ by $Π$, $Π^{-1}(\{p\})$ is called a fiber $F$.
Bundle projection can be performed using function [`bundle_projection`](@ref).

`Manifolds.jl` primarily deals with the case of trivial bundles, where $E$ can be identified with a product $M ×F$.
`Manifolds.jl` primarily deals with the case of trivial bundles, where $E$ can be topologically identified with a product $M×F$.

[Vector bundles](@ref VectorBundleSection) is a special case of a fiber bundle. Other examples include unit tangent bundle. Note that in general fiber bundles don't have a canonical Riemannian structure but can at least be equipped with an [Ehresmann connection](https://en.wikipedia.org/wiki/Ehresmann_connection), providing notions of parallel transport and curvature.

Expand Down
2 changes: 1 addition & 1 deletion src/manifolds/QuotientManifold.jl
Original file line number Diff line number Diff line change
Expand Up @@ -177,7 +177,7 @@ end

@doc raw"""
vertical_component(N::AbstractManifold, p, X)
vertical_compontent(QuotientManifold{M,N}, p, X)
vertical_component(QuotientManifold{M,N}, p, X)
kellertuer marked this conversation as resolved.
Show resolved Hide resolved

Compute the vertical component of tangent vector `X` at point `p`
in the total space of quotient manifold `N`.
Expand Down
5 changes: 3 additions & 2 deletions test/ambiguities.jl
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
"""
has_type_in_signature(sig, T)
Test whether the signature `sig` has an argument of type `T` as one of its paramaters
has_type_in_signature(sig, T::Type)

Test whether the signature `sig` has an argument of type `T` as one of its parameters.
"""
function has_type_in_signature(sig, T::Type)
return any(map(Base.unwrap_unionall(sig.sig).parameters) do x
Expand Down
Loading