-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Symplectic Grassmann #700
Symplectic Grassmann #700
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #700 +/- ##
==========================================
- Coverage 99.54% 94.87% -4.67%
==========================================
Files 108 112 +4
Lines 10715 10871 +156
==========================================
- Hits 10666 10314 -352
- Misses 49 557 +508 ☔ View full report in Codecov by Sentry. |
…c element instead of Q and/or J.
…entation on symplectic Grassmann.
…to write so long messages here.
With the last few methods now I would consider this feature-complete (just not yet test&docs complete), so I moved it from draft to ready (but did not yet set the label). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I haven't read the actual new stuff but here are some small technical comments.
This now covers all I wanted to be included. I already bumped the version, but I would also like to include the Multinomial PR (#702) in this version I think, since that one is basically finished as well. |
It looks like tolerance in one test for SymplecticStiefel is too low. |
I am already running this locally. I am a bit surprised by that since I did not change that. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few comments.
Co-authored-by: Mateusz Baran <[email protected]>
Co-authored-by: Mateusz Baran <[email protected]>
…/Manifolds.jl into kellertuer/more-grassmann
Co-authored-by: Mateusz Baran <[email protected]>
Co-authored-by: Mateusz Baran <[email protected]>
Co-authored-by: Mateusz Baran <[email protected]>
Co-authored-by: Mateusz Baran <[email protected]>
Co-authored-by: Mateusz Baran <[email protected]>
…/Manifolds.jl into kellertuer/more-grassmann
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
this PR is a start to implement the (real) Symplectic Grassmann, which one obtains from Symplectic Stiefel the same way one obtains Grassmann from Stiefel.
It will probably also revise a few symplectic Stiefel functions.
Hamiltonian
, they allow forH^+
to be nicely defined for the symplectic inverseHamiltonianMatrices
? Maybe not 100% necessary but nice for completenessSymplecticGrassmann
inner
(after (4.10) / Lemma 4.8, BZ21)test/utils.jl
functions complain since Julia 1.10 to be multiply included. We should at least move those, if not also the constants to the Manufolds.jl/Test.jl extension?SymplecticMatrix
).symplectic_inverse
when writingp^+
instead of repeating the formula.rand_hamiltonian
to berand(Hamiltonian(2n))
Symplectic
andSymplecticStiefel
, so they getrand!
methods as well. They currently just haverand
methodsBoth symplectic Stiefel and Grassmann stem from this paper https://arxiv.org/abs/2108.12447