Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #539 #540

Merged
merged 3 commits into from
Oct 5, 2022
Merged

Fix #539 #540

merged 3 commits into from
Oct 5, 2022

Conversation

mateuszbaran
Copy link
Member

This should resolve #539 .

@codecov
Copy link

codecov bot commented Oct 4, 2022

Codecov Report

Merging #540 (fa91bed) into master (d817d1c) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master     #540   +/-   ##
=======================================
  Coverage   98.93%   98.93%           
=======================================
  Files          96       96           
  Lines        9268     9278   +10     
=======================================
+ Hits         9169     9179   +10     
  Misses         99       99           
Impacted Files Coverage Δ
src/manifolds/MetricManifold.jl 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@mateuszbaran
Copy link
Member Author

@kellertuer would it be fine to merge it? I'd like to merge it before #533 as a bugfix.

Copy link
Member

@kellertuer kellertuer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, sure, looks good to me.

@mateuszbaran mateuszbaran merged commit c5b4990 into master Oct 5, 2022
@kellertuer kellertuer deleted the mbaran/fix-539 branch May 4, 2024 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

norm for MetricManifold calls inner of base manifold
2 participants