norm for MetricManifold calls inner of base manifold

[sethaxen]

norm for MetricManifold should call inner for that same manifold, but it instead seems to call inner from the base manifold. e.g.

julia> using Manifolds

julia> struct SomeMetric <: RiemannianMetric end

julia> Manifolds.inner(::MetricManifold{ℝ,<:AbstractManifold{ℝ},SomeMetric}, p, X, Y) = 3

julia> M = Sphere(2);

julia> p = project(M, randn(3));

julia> X = project(M, p, randn(3));

julia> inner(MetricManifold(M, SomeMetric()), p, X, X) # expected: 3
3

julia> norm(MetricManifold(M, SomeMetric()), p, X)^2  # expected: 3
3.6649191335512095

julia> norm(X)^2
3.6649191335512095

[mateuszbaran]

Weird that it wasn't discovered earlier, @kellertuer I think #540 should be the best way to fix it (embedding type should not be forwarded when the metric is not default).

[kellertuer]

That's really strange, especially since MetricManifold is meant to (among others) have these alternatives for inner, but how much is inner than different from exp/log where this definitely already worked?

[mateuszbaran]

I've replied regarding differences in #540 (comment) .