-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adapt to Julia 1.11 #50
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #50 +/- ##
==========================================
+ Coverage 95.46% 96.02% +0.56%
==========================================
Files 21 22 +1
Lines 375 428 +53
==========================================
+ Hits 358 411 +53
Misses 17 17 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
Thanks for the PR! I think my only hesitation would be, that this would be the very first package in our ecosystem to drop 1.6-1.9 support. I like the idea with |
If that version of the language itself is not maintained, should package developers really be expected to keep it alive? |
That sounds like a fair argument, sure. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm also fine with bumping Julia requirement 1.10
Nice. @gdalle is it ok if we merge this on master but only register it together with the addition of DI? |
Sure, but note that I bumped the version to v0.3.14 because dropping an old Julia version is not breaking. On the other hand, DI integration will probably be breaking and require a bump to v0.4.0 |
Then 0.3.14 can still chill unregistered on main - and if you have a breaking PR for DI, then it chilled but never got registered. That would be fine with me. |
Sounds good. Plus it allows you to make other changes and register them before the DI PR comes along |
Yes – great. |
Hi there, I was looking at ways to tackle #49 and I thought that if you want to use DI, we might as well upgrate to Julia 1.10 because I dropped 1.6 when the new LTS was announced.
Here are a few changes, feel free to take them or leave them:
lts
,1
(stable release) andpre
(upcoming pre-release)