Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using DifferentiationInterface for AD #49

Closed
gdalle opened this issue Nov 23, 2024 · 5 comments · Fixed by #51
Closed

Using DifferentiationInterface for AD #49

gdalle opened this issue Nov 23, 2024 · 5 comments · Fixed by #51

Comments

@gdalle
Copy link
Contributor

gdalle commented Nov 23, 2024

Hi @kellertuer @mateuszbaran,

Would you would like to try DifferentiationInterface.jl to handle the various AD backends in a unified manner? This would allow you to get rid of the extensions, and probably simplify some code.
I'm happy to lend a hand.

Related:

@kellertuer
Copy link
Member

That would for sure be super nice to have!

I am currently quite busy with the rework of Lie groups into the forthcoming package https://github.com/JuliaManifolds/LieGroups.jl, so for now I do not have the capacity to work on this.

@gdalle
Copy link
Contributor Author

gdalle commented Nov 23, 2024

Would you be open to a PR from me? Not sure I can make all the necessary changes but I can get you most of the way there

@kellertuer
Copy link
Member

Sure, would even be very happy bout that, because it would open this package to more backends – so yes that would be great!

@gdalle
Copy link
Contributor Author

gdalle commented Nov 23, 2024

Alright then, I'll get started! #50 is a very small prelude to DI integration

@mateuszbaran
Copy link
Member

Thanks, this is a good idea 👍 . I thought about integrating with AbstractDifferentiation.jl as you can see. In the end it turned out that I don't need reverse mode for anything I do in Julia (thanks to matrixcalculus.org), and for forward mode ForwardDiff.jl was good enough. But DI would definitely be useful for Manopt.jl.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants