Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add size(::RQPackedQ) #32

Merged
merged 2 commits into from
Mar 29, 2022
Merged

Add size(::RQPackedQ) #32

merged 2 commits into from
Mar 29, 2022

Conversation

dkarrasch
Copy link
Member

I somehow overlooked that in my previous PR. Interestingly, RQPackedQ is not subtyping LayoutQ, so it's not affected by the generic size method.

@codecov
Copy link

codecov bot commented Mar 29, 2022

Codecov Report

Merging #32 (5047e20) into master (02e6b7b) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master      #32   +/-   ##
=======================================
  Coverage   93.01%   93.02%           
=======================================
  Files           7        7           
  Lines        1045     1046    +1     
=======================================
+ Hits          972      973    +1     
  Misses         73       73           
Impacted Files Coverage Δ
src/rq.jl 94.67% <100.00%> (+0.02%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 02e6b7b...5047e20. Read the comment docs.

@dlfivefifty
Copy link
Member

The fact that RQPackedQ is not <: LayoutQ is probably an oversight but we can leave that for now. LayoutQ is only really useful for ∞-dimensional factorisations as implemented in InfiniteLinearAlgebra.jl.

@dlfivefifty dlfivefifty merged commit a5aea60 into master Mar 29, 2022
@dkarrasch dkarrasch deleted the dkarrasch-patch-1 branch March 29, 2022 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants