Skip to content

Commit

Permalink
Add size(::RQPackedQ) (#32)
Browse files Browse the repository at this point in the history
* Update rq.jl

* Update Project.toml
  • Loading branch information
dkarrasch authored Mar 29, 2022
1 parent 02e6b7b commit a5aea60
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 1 deletion.
2 changes: 1 addition & 1 deletion Project.toml
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
name = "MatrixFactorizations"
uuid = "a3b82374-2e81-5b9e-98ce-41277c0e4c87"
version = "0.9"
version = "0.9.1"

[deps]
ArrayLayouts = "4c555306-a7a7-4459-81d9-ec55ddd5c99a"
Expand Down
1 change: 1 addition & 0 deletions src/rq.jl
Original file line number Diff line number Diff line change
Expand Up @@ -119,6 +119,7 @@ AbstractMatrix{T}(Q::RQPackedQ) where {T} = RQPackedQ{T}(Q)

Matrix{T}(Q::RQPackedQ{S}) where {T,S} = Matrix{T}(lmul!(Q, Matrix{S}(I, size(Q,2), size(Q,2))))
Base.size(Q::RQPackedQ, dim::Integer) = size(getfield(Q, :factors), dim == 1 ? 2 : dim)
Base.size(Q::RQPackedQ) = size(Q, 1), size(Q, 2)

function lmul!(A::RQPackedQ{T,S}, B::StridedVecOrMat{T}) where {T<:BlasFloat, S<:StridedMatrix}
m,n = size(A.factors)
Expand Down

2 comments on commit a5aea60

@dlfivefifty
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JuliaRegistrator
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Registration pull request created: JuliaRegistries/General/57550

After the above pull request is merged, it is recommended that a tag is created on this repository for the registered package version.

This will be done automatically if the Julia TagBot GitHub Action is installed, or can be done manually through the github interface, or via:

git tag -a v0.9.1 -m "<description of version>" a5aea60e424030b505e70aff64231dc03c29a4e9
git push origin v0.9.1

Please sign in to comment.